From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atc1v-0003bo-2J for qemu-devel@nongnu.org; Fri, 22 Apr 2016 10:26:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1atc1q-0005cd-Gx for qemu-devel@nongnu.org; Fri, 22 Apr 2016 10:25:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atc1q-0005cW-90 for qemu-devel@nongnu.org; Fri, 22 Apr 2016 10:25:54 -0400 References: <1460096797-14916-1-git-send-email-zhang.zhanghailiang@huawei.com> <1460096797-14916-22-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <571A346E.1020403@redhat.com> Date: Fri, 22 Apr 2016 08:25:50 -0600 MIME-Version: 1.0 In-Reply-To: <1460096797-14916-22-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MnbuVnhkD7lTQVORGIQJu2HHGGVA9dD4g" Subject: Re: [Qemu-devel] [PATCH COLO-Frame v16 21/35] qmp event: Add COLO_EXIT event to notify users while exited from COLO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, quintela@redhat.com, dgilbert@redhat.com, peter.huangpeng@huawei.com, eddie.dong@intel.com, yunhong.jiang@intel.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, arei.gonglei@huawei.com, stefanha@redhat.com, hongyang.yang@easystack.cn, zhangchen.fnst@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, armbru@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MnbuVnhkD7lTQVORGIQJu2HHGGVA9dD4g Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/08/2016 12:26 AM, zhanghailiang wrote: > If some errors happen during VM's COLO FT stage, it's important to noti= fy the users > of this event. Together with 'x_colo_lost_heartbeat', users can interve= ne in COLO's > failover work immediately. > If users don't want to get involved in COLO's failover verdict, > it is still necessary to notify users that we exited COLO mode. >=20 > Cc: Markus Armbruster > Cc: Michael Roth > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > --- > +++ b/migration/colo.c > @@ -18,6 +18,7 @@ > #include "qemu/error-report.h" > #include "qapi/error.h" > #include "migration/failover.h" > +#include "qapi-event.h" > =20 > /* colo buffer */ > #define COLO_BUFFER_BASE_SIZE (4 * 1024 * 1024) > @@ -368,6 +369,18 @@ out: > if (local_err) { > error_report_err(local_err); > } > + /* > + * There are only two reasons we can go here, something error happe= ned, > + * Or users triggered failover. s/something/some/ s/Or users/or the user/ Otherwise looks fine. As comments are minor fixes, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MnbuVnhkD7lTQVORGIQJu2HHGGVA9dD4g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXGjRvAAoJEKeha0olJ0Nqc9QH/iffmbk1aLHmikbH68G0Z9v2 hNsYFbEzgYoDe22tD4uxbagGFfI1+UUgWu7HYwhnxgoMlA+mEr2SbEcdSfyy0/kJ ul9ggop2qShw7wJzgynHXmwxr+yKC5zGnzfoLJoRRMWO6rdm89hrE+QaZDp8/A0A Krhx0gOCcBXxKeNMrzb2HrOfdzKPfjgKC5+eVCkPNTkVfnuW9RKVJ2yO3EJyM+QS MJ38U4mIppqqUBTMYh6k6WxvSlGGgcZl8Ri3F2fJ8PJjxrGGemUtd+ft39rZu1eW y1j3RqpxPON5T1c1n0HiR68CU8GHPLJ/WCTP+904F2TSuuF5BzReif01uWLlCaM= =rCO/ -----END PGP SIGNATURE----- --MnbuVnhkD7lTQVORGIQJu2HHGGVA9dD4g--