From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] utils.bbclass: warn for deprecated base_contains
Date: Fri, 22 Apr 2016 22:34:15 +0800 [thread overview]
Message-ID: <571A3667.7070407@windriver.com> (raw)
In-Reply-To: <CAJTo0LYjvdtzq=q-f+BPNi7k3OraKV_Hez-TZmRucCWYmf0D8A@mail.gmail.com>
On 04/22/2016 07:15 PM, Burton, Ross wrote:
>
> On 22 April 2016 at 06:44, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
> + bb.warn('base_contains is depracated, please use bb.utils.contains
> instead.')
>
>
> WARN seems a bit excessive. Would a NOTE be visible in the output?
Yes, it is visible since it is happened in parsing.
>
> Also typo, "deprecated".
Sorry, updated in the repo:
* warn -> note
* depracated -> deprecated
git://git.openembedded.org/openembedded-core-contrib rbt/warn
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/warn
Robert Yang (2):
directfb/pango/webkit: base_contains -> bb.utils.contains
utils.bbclass: warn for deprecated base_contains
Author: Robert Yang <liezhi.yang@windriver.com>
Date: Thu Apr 21 20:21:22 2016 -0700
utils.bbclass: note for deprecated base_contains
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 81b92cb..ce639b2 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -24,6 +24,7 @@ def base_version_less_or_equal(variable, checkvalue,
truevalue, falsevalue, d):
return oe.utils.version_less_or_equal(variable, checkvalue, truevalue,
falsevalue, d)
def base_contains(variable, checkvalues, truevalue, falsevalue, d):
+ bb.note('base_contains is deprecated, please use bb.utils.contains instead.')
return bb.utils.contains(variable, checkvalues, truevalue, falsevalue, d)
def base_both_contain(variable1, variable2, checkvalue, d):
// Robert
>
> Ross
prev parent reply other threads:[~2016-04-22 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 5:44 [PATCH 0/2] ase_contains -> bb.utils.contains (master branch only) Robert Yang
2016-04-22 5:44 ` [PATCH 1/2] directfb/pango/webkit: base_contains -> bb.utils.contains Robert Yang
2016-04-22 5:44 ` [PATCH 2/2] utils.bbclass: warn for deprecated base_contains Robert Yang
2016-04-22 11:15 ` Burton, Ross
2016-04-22 14:34 ` Robert Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571A3667.7070407@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.