From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============8257297582581210980=="
MIME-Version: 1.0
From: Denis Kenzior <denkenz@gmail.com>
Subject: Re: [PATCH 1/5] modem: clean up atoms on modem_unregister
Date: Fri, 22 Apr 2016 14:25:15 -0500
Message-ID: <571A7A9B.3010806@gmail.com>
In-Reply-To: <1461330431-20206-2-git-send-email-john.ernberg@actia.se>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============8257297582581210980==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi John,

On 04/22/2016 08:07 AM, John Ernberg wrote:
> From: John Ernberg <john.ernberg@actia.se>
>
> This resolves a crash that can happen when a e.g. usb modem is removed.
> ---
>   src/modem.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/modem.c b/src/modem.c
> index a89fa48..4968839 100644
> --- a/src/modem.c
> +++ b/src/modem.c
> @@ -2071,6 +2071,9 @@ static void modem_unregister(struct ofono_modem *mo=
dem)
>   	if (modem->powered =3D=3D TRUE)
>   		set_powered(modem, FALSE);
>

So in theory, set_powered calls flush_atoms...

> +	if (modem->atoms)
> +		flush_atoms(modem, MODEM_STATE_POWER_OFF);
> +

So why is this needed?

Do you have a stack trace handy?

>   	__ofono_watchlist_free(modem->atom_watches);
>   	modem->atom_watches =3D NULL;
>
>

Regards,
-Denis

--===============8257297582581210980==--