From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t4622.austin.hp.com (g2t4622.austin.hp.com [15.73.212.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC1D01A20FA for ; Fri, 22 Apr 2016 16:07:50 -0700 (PDT) Subject: Re: [ndctl PATCH 7/8] ndctl, create-namespace: fix sector mode default for pmem namespaces References: <146135442234.4228.904225076597683142.stgit@dwillia2-desk3.amr.corp.intel.com> <146135445871.4228.1090587699596226202.stgit@dwillia2-desk3.amr.corp.intel.com> From: Linda Knippers Message-ID: <571AAEC4.8090503@hpe.com> Date: Fri, 22 Apr 2016 19:07:48 -0400 MIME-Version: 1.0 In-Reply-To: <146135445871.4228.1090587699596226202.stgit@dwillia2-desk3.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams , linux-nvdimm@lists.01.org List-ID: On 4/22/2016 3:47 PM, Dan Williams wrote: > The man page uses the following example for establishing a sector mode > namespace: > > ndctl create-namespace -e namespace0.0 -f -m sector > > ...however this only works for blk-type namespaces to inherit a default > sector size. Default to 4K in the pmem-type namespaces. > > Reported-by: Linda Knippers > Signed-off-by: Dan Williams Thanks Dan. Tested-by: Linda Knippers > --- > builtin-xaction-namespace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/builtin-xaction-namespace.c b/builtin-xaction-namespace.c > index 7d555a7d14a1..6ae8d7aee849 100644 > --- a/builtin-xaction-namespace.c > +++ b/builtin-xaction-namespace.c > @@ -410,6 +410,8 @@ static int validate_namespace_options(struct ndctl_namespace *ndns, > else if (ndctl_namespace_get_type(ndns) > == ND_DEVICE_NAMESPACE_BLK) > p->sector_size = ndctl_namespace_get_sector_size(ndns); > + else if (p->mode == NDCTL_NS_MODE_SAFE) > + p->sector_size = 4096; > } > > if (param.map) { > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm