From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jiri Benc <jbenc@redhat.com>, netdev@vger.kernel.org
Cc: Pravin B Shelar <pshelar@nicira.com>, Thomas Graf <tgraf@suug.ch>,
Simon Horman <simon.horman@netronome.com>
Subject: Re: [PATCH net v2 1/3] gre: do not assign header_ops in collect metadata mode
Date: Sun, 24 Apr 2016 16:45:04 +0300 [thread overview]
Message-ID: <571CCDE0.9060902@cogentembedded.com> (raw)
In-Reply-To: <bd50f4691e9edc28c5a9ec861863f7f6cf316077.1461495411.git.jbenc@redhat.com>
Hello.
On 4/24/2016 2:00 PM, Jiri Benc wrote:
> In ipgre mode (i.e. not gretap) with collect metadata flag set, the tunnel
> is incorrectly assumed to be mGRE in NBMA mode (see commit 6a5f44d7a048c).
Didn't checkpatch.pl complain about the commit citing style?
> This is not the case, we're controlling the encapsulation addresses by
> lwtunnel metadata. And anyway, assigning dev->header_ops in collect metadata
> mode does not make sense.
>
> Similarly, when a multicast remote IP address is set together with the
> collect metadata flag, the processing described above would happen, too. As
> there's not much sense in specifying remote/local IP address for lwtunnels,
> reject such configuration.
>
> v2: Reject configuration specifying both remote/local address and collect
> metadata flag.
>
> Fixes: 2e15ea390e6f4 ("ip_gre: Add support to collect tunnel metadata.")
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-04-24 13:45 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 12:47 [PATCH net-next v3 0/4] vxlan: implement Generic Protocol Extension (GPE) Jiri Benc
2016-04-05 12:47 ` [PATCH net-next v3 1/4] vxlan: move Ethernet initialization to a separate function Jiri Benc
2016-04-05 12:47 ` [PATCH net-next v3 2/4] vxlan: move fdb code to common location in vxlan_xmit Jiri Benc
2016-04-05 12:47 ` [PATCH net-next v3 3/4] ip_tunnel: implement __iptunnel_pull_header Jiri Benc
2016-04-05 12:47 ` [PATCH net-next v3 4/4] vxlan: implement GPE Jiri Benc
2016-04-06 12:52 ` [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks Sjoerd Simons
2016-04-06 12:52 ` Sjoerd Simons
2016-04-06 13:09 ` Geert Uytterhoeven
2016-04-06 13:09 ` Geert Uytterhoeven
2016-04-06 13:09 ` Geert Uytterhoeven
2016-04-06 13:11 ` Geert Uytterhoeven
2016-04-06 13:11 ` Geert Uytterhoeven
2016-04-06 13:37 ` Sjoerd Simons
2016-04-06 13:37 ` Sjoerd Simons
2016-04-06 13:37 ` Sjoerd Simons
2016-04-07 23:21 ` Stephen Boyd
2016-04-07 23:21 ` Stephen Boyd
2016-04-08 10:50 ` Sjoerd Simons
2016-04-08 10:50 ` Sjoerd Simons
2016-04-08 10:50 ` Sjoerd Simons
2016-04-14 0:19 ` Stephen Boyd
2016-04-14 0:19 ` Stephen Boyd
2016-04-14 0:19 ` Stephen Boyd
2016-04-06 23:15 ` Sergei Shtylyov
2016-04-06 23:15 ` Sergei Shtylyov
2016-04-05 13:50 ` [PATCH net-next v3 4/4] vxlan: implement GPE, Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks, No serial since ARM: dts: r8a7791: Add BRG support for (H)SCIF, [PATCH net v2 1/3] gre: do not assign header_ops in collect metadata mode, [PATCH iproute2 0/2] ip link gre: fix external mode handling, [PATCH 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions Tom Herbert, Sergei Shtylyov, Sjoerd Simons, Jiri Benc, Jiri Benc, Simon Horman
2016-04-07 7:00 ` [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks Sjoerd Simons
2016-04-07 7:00 ` Sjoerd Simons
2016-04-07 7:00 ` Sjoerd Simons
2016-04-07 19:14 ` Sergei Shtylyov
2016-04-07 19:14 ` Sergei Shtylyov
2016-04-08 14:20 ` Phil Edworthy
2016-04-08 14:20 ` Phil Edworthy
2016-04-08 14:20 ` Phil Edworthy
2016-04-19 7:18 ` Geert Uytterhoeven
2016-04-19 7:18 ` Geert Uytterhoeven
2016-04-19 7:18 ` Geert Uytterhoeven
2016-04-19 22:51 ` Simon Horman
2016-04-19 22:51 ` Simon Horman
2016-04-24 11:00 ` [PATCH net v2 0/3] gre: fix lwtunnel support Jiri Benc
2016-04-21 3:44 ` [GIT PULL] Renesas ARM Based SoC R-Car SYSC Updates for v4.7 Simon Horman
2016-04-21 3:44 ` [PATCH 1/7] PM / Domains: Add DT bindings for the R-Car System Controller Simon Horman
2016-04-21 3:44 ` Simon Horman
2016-04-21 3:44 ` [PATCH 2/7] soc: renesas: Add r8a7779 SYSC PM Domain Binding Definitions Simon Horman
2016-04-21 3:44 ` Simon Horman
2016-04-21 3:44 ` [PATCH 3/7] soc: renesas: Add r8a7790 " Simon Horman
2016-04-05 13:50 ` [PATCH net-next v3 4/4] vxlan: implement GPE, Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks, No serial since ARM: dts: r8a7791: Add BRG support for (H)SCIF, [PATCH net v2 1/3] gre: do not assign header_ops in collect metadata mode, [PATCH iproute2 0/2] ip link gre: fix external mode handling, " Tom Herbert, Sergei Shtylyov, Sjoerd Simons, Jiri Benc, Jiri Benc, Simon Horman
2016-04-05 13:50 ` [PATCH net-next v3 4/4] vxlan: implement GPE Tom Herbert
2016-04-05 13:57 ` Jiri Benc
2016-04-21 3:44 ` [PATCH 4/7] soc: renesas: Add r8a7791 SYSC PM Domain Binding Definitions Simon Horman
2016-04-21 3:44 ` Simon Horman
2016-04-21 3:44 ` [PATCH 5/7] soc: renesas: Add r8a7793 " Simon Horman
2016-04-21 3:44 ` Simon Horman
2016-04-21 3:44 ` [PATCH 6/7] soc: renesas: Add r8a7794 " Simon Horman
2016-04-21 3:44 ` [PATCH 7/7] soc: renesas: Add r8a7795 " Simon Horman
2016-04-24 21:40 ` [GIT PULL] Renesas ARM Based SoC R-Car SYSC Updates for v4.7 Arnd Bergmann
2016-04-25 0:23 ` Simon Horman
2016-04-24 11:00 ` [PATCH net v2 1/3] gre: do not assign header_ops in collect metadata mode Jiri Benc
2016-04-24 13:45 ` Sergei Shtylyov [this message]
2016-04-26 8:39 ` Jiri Benc
2016-04-27 14:11 ` [PATCH iproute2 0/2] ip link gre: fix external mode handling Jiri Benc
2016-04-27 14:11 ` [PATCH iproute2 1/2] ip link gre: create interfaces in external mode correctly Jiri Benc
2016-04-27 14:11 ` [PATCH iproute2 2/2] ip link gre: print only relevant info in external mode Jiri Benc
2016-05-06 18:50 ` [PATCH iproute2 0/2] ip link gre: fix external mode handling Stephen Hemminger
2016-04-24 11:00 ` [PATCH net v2 2/3] gre: build header correctly for collect metadata tunnels Jiri Benc
2016-04-24 11:00 ` [PATCH net v2 3/3] gre: allow creation of gretap interfaces in metadata mode Jiri Benc
2016-04-25 18:00 ` pravin shelar
2016-04-26 8:47 ` Jiri Benc
2016-04-06 20:50 ` [PATCH net-next v3 0/4] vxlan: implement Generic Protocol Extension (GPE) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571CCDE0.9060902@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=simon.horman@netronome.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.