From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1auaip-00027F-NU
	for qemu-devel@nongnu.org; Mon, 25 Apr 2016 03:14:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1auail-0000Hr-HP
	for qemu-devel@nongnu.org; Mon, 25 Apr 2016 03:14:19 -0400
Received: from goliath.siemens.de ([192.35.17.28]:54769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1auail-0000Gl-1i
	for qemu-devel@nongnu.org; Mon, 25 Apr 2016 03:14:15 -0400
References: <1461535977-331-1-git-send-email-davidkiarie4@gmail.com>
	<CABdVeAB5wYgL8+N_fR=kNDeW2pvx-Y0BeEM3+12WkbD1RYnSXg@mail.gmail.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <571DC3B2.4090604@siemens.com>
Date: Mon, 25 Apr 2016 09:13:54 +0200
MIME-Version: 1.0
In-Reply-To: <CABdVeAB5wYgL8+N_fR=kNDeW2pvx-Y0BeEM3+12WkbD1RYnSXg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V9 0/4] AMD IOMMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Kiarie <davidkiarie4@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>
Cc: Valentine Sinitsyn <valentine.sinitsyn@gmail.com>, Marcel Apfelbaum <marcel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, imammedo@redhat.com

On 2016-04-25 00:16, David Kiarie wrote:
> Sorry, I keep missing Jan's email...

No problem.

I'm planning to give this version a try soon and will also look into
some details for a review.

Jan

> 
> On Mon, Apr 25, 2016 at 1:12 AM, David Kiarie <davidkiarie4@gmail.com> wrote:
>> Hi all,
>>
>> The current AMD IOMMU patches that fixes Igor's comments. I got rid of structs and instead
>> added individual integer fields into the table data directly, as suggested.
>>
>> I have also got rid of some un-used macros and fixed a few other miscellaneous things.
>>
>> David Kiarie (4):
>>   hw/i386: Introduce AMD IOMMU
>>   hw/i386: ACPI table for AMD IOMMU
>>   hw/core: Add AMD IOMMU to machine properties
>>   hw/pci-host: Emulate AMD IOMMU
>>
>>  hw/acpi/aml-build.c           |    2 +-
>>  hw/acpi/core.c                |   13 -
>>  hw/core/machine.c             |   32 +-
>>  hw/i386/Makefile.objs         |    1 +
>>  hw/i386/acpi-build.c          |  101 ++-
>>  hw/i386/amd_iommu.c           | 1426 +++++++++++++++++++++++++++++++++++++++++
>>  hw/i386/amd_iommu.h           |  398 ++++++++++++
>>  hw/pci-host/q35.c             |   21 +-
>>  include/hw/acpi/acpi-defs.h   |   14 +
>>  include/hw/acpi/acpi.h        |   16 +
>>  include/hw/acpi/aml-build.h   |    1 +
>>  include/hw/boards.h           |    1 +
>>  include/hw/i386/intel_iommu.h |    1 +
>>  include/hw/pci/pci.h          |    2 +
>>  qemu-options.hx               |    7 +-
>>  util/qemu-config.c            |    8 +-
>>  16 files changed, 2010 insertions(+), 34 deletions(-)
>>  create mode 100644 hw/i386/amd_iommu.c
>>  create mode 100644 hw/i386/amd_iommu.h
>>
>> --
>> 2.1.4
>>


-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux