All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] i2c: s3c2410: fix indentation for better readability
Date: Mon, 25 Apr 2016 10:55:07 +0200	[thread overview]
Message-ID: <571DDB6B.6000704@samsung.com> (raw)
In-Reply-To: <1461533338-17479-1-git-send-email-wsa@the-dreams.de>

On 04/24/2016 11:28 PM, Wolfram Sang wrote:
> smatch rightfully says:
> 
> drivers/i2c/busses/i2c-s3c2410.c:1217 s3c24xx_i2c_probe() warn: inconsistent indenting
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Hi,

You could just apply this one:
i2c: s3c2410: Cleanup indentation and comment style
https://lkml.org/lkml/2016/4/20/163

I fixed this in that patch. Its trivial so it does not have to be a
separate patch.

Best regards,
Krzysztof

> 
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 1bc756313cb8e4..315c88ea1fa153 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1214,8 +1214,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>  			return ret;
>  		}
>  
> -	ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
> -				dev_name(&pdev->dev), i2c);
> +		ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
> +				       dev_name(&pdev->dev), i2c);
>  
>  		if (ret != 0) {
>  			dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq);
> 

      reply	other threads:[~2016-04-25  8:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 21:28 [PATCH] i2c: s3c2410: fix indentation for better readability Wolfram Sang
2016-04-25  8:55 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571DDB6B.6000704@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.