From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1auctw-0002kL-LR
	for qemu-devel@nongnu.org; Mon, 25 Apr 2016 05:33:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1aucts-00075A-FH
	for qemu-devel@nongnu.org; Mon, 25 Apr 2016 05:33:56 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:54635)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1auctr-00074Y-UV
	for qemu-devel@nongnu.org; Mon, 25 Apr 2016 05:33:52 -0400
References: <1460096797-14916-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1460096797-14916-22-git-send-email-zhang.zhanghailiang@huawei.com>
	<571A346E.1020403@redhat.com>
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Message-ID: <571DE461.5070109@huawei.com>
Date: Mon, 25 Apr 2016 17:33:21 +0800
MIME-Version: 1.0
In-Reply-To: <571A346E.1020403@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v16 21/35] qmp event: Add
 COLO_EXIT event to notify users while exited from COLO
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: peter.huangpeng@huawei.com, amit.shah@redhat.com, quintela@redhat.com, dgilbert@redhat.com, eddie.dong@intel.com, yunhong.jiang@intel.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, arei.gonglei@huawei.com, stefanha@redhat.com, hongyang.yang@easystack.cn, zhangchen.fnst@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, armbru@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>

On 2016/4/22 22:25, Eric Blake wrote:
> On 04/08/2016 12:26 AM, zhanghailiang wrote:
>> If some errors happen during VM's COLO FT stage, it's important to notify the users
>> of this event. Together with 'x_colo_lost_heartbeat', users can intervene in COLO's
>> failover work immediately.
>> If users don't want to get involved in COLO's failover verdict,
>> it is still necessary to notify users that we exited COLO mode.
>>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>
>> +++ b/migration/colo.c
>> @@ -18,6 +18,7 @@
>>   #include "qemu/error-report.h"
>>   #include "qapi/error.h"
>>   #include "migration/failover.h"
>> +#include "qapi-event.h"
>>
>>   /* colo buffer */
>>   #define COLO_BUFFER_BASE_SIZE (4 * 1024 * 1024)
>> @@ -368,6 +369,18 @@ out:
>>       if (local_err) {
>>           error_report_err(local_err);
>>       }
>> +    /*
>> +    * There are only two reasons we can go here, something error happened,
>> +    * Or users triggered failover.
>
> s/something/some/
> s/Or users/or the user/
>
> Otherwise looks fine. As comments are minor fixes,
> Reviewed-by: Eric Blake <eblake@redhat.com>
>

Thanks very much, I'll fix them in next version.

Hailiang