From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atomic: Always allow async support for the atomic ioctl.
Date: Mon, 25 Apr 2016 11:37:34 +0200 [thread overview]
Message-ID: <571DE55E.8050103@linux.intel.com> (raw)
In-Reply-To: <CAKMK7uHE7QEJjB47ZPauQWuekNLRj9LUnz_Rfqzb2PnT3t4Row@mail.gmail.com>
Op 25-04-16 om 11:35 schreef Daniel Vetter:
> On Mon, Apr 25, 2016 at 11:21 AM, Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com> wrote:
>> async_page_flip is a unrelated flag and should not be used for
>> testing support. It's up to the drivers to fail if they don't
>> support async commit.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Once more (summary of our irc discussion):
>
> - DRM_MODE_PAGE_FLIP_ASYNC = flipping with tearing, i.e. not vblank
> synced. Gives you lower latency and unrestricted rendering, aka
> benchmark mode. Needs special hw support and on intel only supported
> on the primary plane. I think a better way to almost get all the
> benefits of async by simply implementing a queue of flips that all get
> collapsed to the next vblank.
>
> - async atomic commit = non-blocking ioctl.
>
> Two entirely orthogonal things (you could do blocking atomic commit
> with async flip, but doesn't make much sense).
>
> Maybe instead we need a better documentation for the FLIP_ASYNC flag?
>
yeah it's confusing, especially with atomic async commit. Maybe rename to nonblocking commit?
~Maarten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-25 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 9:21 [PATCH] drm/atomic: Always allow async support for the atomic ioctl Maarten Lankhorst
2016-04-25 9:35 ` Daniel Vetter
2016-04-25 9:37 ` Maarten Lankhorst [this message]
2016-04-25 9:40 ` Daniel Vetter
2016-04-25 12:05 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571DE55E.8050103@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.