From: Crestez Dan Leonard <leonard.crestez@intel.com>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Daniel Baluta <daniel.baluta@intel.com>
Subject: Re: [PATCH 3/5] iio: inv_mpu6050: Check WHO_AM_I register on probe
Date: Mon, 25 Apr 2016 14:17:59 +0300 [thread overview]
Message-ID: <571DFCE7.1030300@intel.com> (raw)
In-Reply-To: <db4459f9-7cb4-ff85-658d-a21f363aee3a@kernel.org>
On 04/24/2016 02:14 PM, Jonathan Cameron wrote:
> On 20/04/16 14:15, Crestez Dan Leonard wrote:
>> This can be used to distinguish mpu6500. This is a warning rather than
>> an error because the differences are mostly irrelevant and it's nice to
>> avoid breaking users with slightly incorrect ACPI/DT.
>>
>> Signed-off-by: Crestez Dan Leonard <leonard.crestez@intel.com>
> Would we be better off fixing their configuration though by using the right part
> if we can identify it? So if wrong, maybe we should search the info table to
> figure out what it is? I'm not certain on this though as then we are trying to
> deal with unknown future cases - maybe what you have here is the best balance.
I'm not sure about that. One issue is that 6000/6050/9150 have the same
WHOAMI value and can't be distinguished this way. They also seem to
identical interfaces. Models MPU6500 and MPU9250 report different WHOAMI
values.
Changing chip_type based on the WHOAMI would require some additional
refactoring. Placing that in a separate patch might be worthwhile anyway.
>> +#define INV_MPU6050_REG_WHOAMI 117
>> +
>> +#define INV_MPU6000_WHOAMI_VALUE 0x68
>> +#define INV_MPU6050_WHOAMI_VALUE 0x68
>> +#define INV_MPU6500_WHOAMI_VALUE 0x70
next prev parent reply other threads:[~2016-04-25 11:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 13:15 [PATCH 0/5] iio: inv_mpu6050: Cleanup chip types and add mpu9150 Crestez Dan Leonard
2016-04-20 13:15 ` [PATCH 1/5] iio: inv_mpu6050: Cleanup hw_info mapping Crestez Dan Leonard
2016-04-24 11:10 ` Jonathan Cameron
2016-04-25 18:41 ` Jonathan Cameron
2016-04-20 13:15 ` [PATCH 2/5] iio: inv_mpu6050: Remove inv_mpu6050_hw.num_reg Crestez Dan Leonard
2016-04-24 11:12 ` Jonathan Cameron
2016-04-25 18:43 ` Jonathan Cameron
2016-04-20 13:15 ` [PATCH 3/5] iio: inv_mpu6050: Check WHO_AM_I register on probe Crestez Dan Leonard
2016-04-24 11:14 ` Jonathan Cameron
2016-04-25 11:17 ` Crestez Dan Leonard [this message]
2016-04-25 18:09 ` Jonathan Cameron
2016-04-20 13:15 ` [PATCH 4/5] iio: inv_mpu6050: Add spi_device_id for INV_MPU6500 Crestez Dan Leonard
2016-04-20 13:15 ` [PATCH 5/5] iio: inv_mpu6050: Add explicit support for MPU9150 Crestez Dan Leonard
2016-04-24 11:16 ` Jonathan Cameron
2016-04-25 17:56 ` Ge Gao
2016-04-25 17:56 ` Ge Gao
2016-04-25 19:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571DFCE7.1030300@intel.com \
--to=leonard.crestez@intel.com \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.