All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] distro: Disable iso partition format for SPL
Date: Mon, 25 Apr 2016 17:03:58 +0200	[thread overview]
Message-ID: <571E31DE.9050001@denx.de> (raw)
In-Reply-To: <1461588930-103058-1-git-send-email-agraf@suse.de>

Hello Alexander,

Am 25.04.2016 um 14:55 schrieb Alexander Graf:
> When building an SPL binary, chances are quite slim that we need an
> iso partition label. However, there were reports of us exceeding our
> SPL memory limit with iso enabled.
>
> So for now, let's disable the ISO partition format code when in the
> SPL build.
>
> Reported-by: Heiko Schocher <hs@denx.de>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>   include/config_distro_defaults.h | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)

Thanks for the fix!

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/include/config_distro_defaults.h b/include/config_distro_defaults.h
> index 5cc2af8..6a72f02 100644
> --- a/include/config_distro_defaults.h
> +++ b/include/config_distro_defaults.h
> @@ -62,9 +62,12 @@
>   #define CONFIG_MENU
>   #define CONFIG_DOS_PARTITION
>   #define CONFIG_EFI_PARTITION
> -#define CONFIG_ISO_PARTITION
>   #define CONFIG_SUPPORT_RAW_INITRD
>   #define CONFIG_SYS_HUSH_PARSER
>   #define CONFIG_ENV_VARS_UBOOT_CONFIG
>
> +#ifndef CONFIG_SPL_BUILD
> +#define CONFIG_ISO_PARTITION
> +#endif
> +
>   #endif	/* _CONFIG_CMD_DISTRO_DEFAULTS_H */
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2016-04-25 15:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 12:55 [U-Boot] [PATCH] distro: Disable iso partition format for SPL Alexander Graf
2016-04-25 15:03 ` Heiko Schocher [this message]
2016-04-25 15:04   ` Alexander Graf
2016-04-25 15:18     ` Heiko Schocher
2016-04-25 15:21       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571E31DE.9050001@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.