From: Florian Fainelli <f.fainelli@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev@vger.kernel.org
Cc: arnd@arndb.de
Subject: Re: [PATCH 1/5] phylib: don't return NULL from get_phy_device()
Date: Mon, 25 Apr 2016 12:45:49 -0700 [thread overview]
Message-ID: <571E73ED.7080603@gmail.com> (raw)
In-Reply-To: <16806435.OmqP10ba8M@wasted.cogentembedded.com>
On 24/04/16 10:25, Sergei Shtylyov wrote:
> Arnd Bergmann asked that get_phy_device() returns either NULL or the error
> value, not both on error. Do as he said, return ERR_PTR(-ENODEV) instead
> of NULL when the PHY ID registers read as all ones.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2016-04-25 19:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 17:23 [PATCH 0/5] Don't return NULL from get_phy_device() anymore Sergei Shtylyov
2016-04-24 17:25 ` [PATCH 1/5] phylib: don't return NULL from get_phy_device() Sergei Shtylyov
2016-04-25 19:45 ` Florian Fainelli [this message]
[not found] ` <874mamzw5q.fsf@ketchup.mtl.sfl>
2016-04-27 19:49 ` Andrew Lunn
2016-04-27 20:09 ` Sergei Shtylyov
2016-04-27 20:23 ` David Miller
2016-04-27 22:03 ` Arnd Bergmann
2016-04-27 21:47 ` Florian Fainelli
2016-04-27 22:07 ` Arnd Bergmann
2016-04-27 20:12 ` Sergei Shtylyov
2016-04-27 20:11 ` Florian Fainelli
2016-04-24 17:27 ` [PATCH 2/5] xgene: get_phy_device() doesn't return NULL anymore Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:29 ` [PATCH 3/5] fixed_phy: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:30 ` [PATCH 4/5] mdio_bus: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:31 ` [PATCH 5/5] of_mdio: " Sergei Shtylyov
2016-04-24 17:37 ` Sergei Shtylyov
2016-04-25 19:47 ` Florian Fainelli
2016-04-26 19:41 ` [PATCH 0/5] Don't return NULL from get_phy_device() anymore David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E73ED.7080603@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.