From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jinpu Wang <jinpu.wang@profitbricks.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
s.parschauer@gmx.de
Subject: Re: [PATCH]sd: Don't treat succeeded SYNC as error
Date: Mon, 25 Apr 2016 13:28:31 -0700 [thread overview]
Message-ID: <571E7DEF.2090005@sandisk.com> (raw)
In-Reply-To: <CAMGffEnAYXdYNfN7aHZHLjnhxY2T2V6m4tPNi4eT4kDuarrYxQ@mail.gmail.com>
On 04/25/2016 03:36 AM, Jinpu Wang wrote:
> We hit IO error on fsync, it turns out was because sd treat succeeded
> SYNC as error. From what I checked in SBC spec there is no indication
> we should fail IO in this case, so we create this patch.
Please follow the rules in Documentation/SubmittingPatches and submit
patches inline. Regarding the patch itself: why is the switch(op)
needed? Can it be left out? And regarding (sshdr.asc == 0x2a &&
sshdr.ascq == 0x09): which other unit attentions should cause SCSI
commands to succeed instead of to fail?
Bart.
next prev parent reply other threads:[~2016-04-25 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 10:36 [PATCH]sd: Don't treat succeeded SYNC as error Jinpu Wang
2016-04-25 20:28 ` Bart Van Assche [this message]
2016-04-26 10:57 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E7DEF.2090005@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=jinpu.wang@profitbricks.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=s.parschauer@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.