From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Philip Oakley <philipoakley@iee.org>, Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] remote.c: spell __attribute__ correctly
Date: Mon, 25 Apr 2016 23:14:38 +0100 [thread overview]
Message-ID: <571E96CE.80606@ramsayjones.plus.com> (raw)
In-Reply-To: <2FDBFACB68254498A8F83367553AED80@PhilipOakley>
On 25/04/16 22:50, Philip Oakley wrote:
> From: "Jeff King" <peff@peff.net>
>> On Mon, Apr 25, 2016 at 05:10:30PM -0400, Jeff King wrote:
>>
>>> It should be handled in git-compat-util.h, which is included by cache.h,
>>> which is included by remote.c.
>>>
>>> There we have:
>>>
>>> #ifndef __GNUC__
>>> #ifndef __attribute__
>>> #define __attribute__(x)
>>> #endif
>>> #endif
>>>
>>> which should make it a noop on compilers which don't know about it. Is
>>> VS (or another file) setting __GNUC__?
>>
>> Of course it helps if we spell the name right...
Indeed! ;-)
Not that it matters, but the above #define in git-compat-util.h is not
the relevant definition - msvc will not see it. However, it does see
the #define on line 12 of compat/msvc.h. :-D
ATB,
Ramsay Jones
next prev parent reply other threads:[~2016-04-25 22:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 21:02 definition for _attribute() in remote.c Philip Oakley
2016-04-25 21:10 ` Jeff King
2016-04-25 21:15 ` [PATCH] remote.c: spell __attribute__ correctly Jeff King
2016-04-25 21:50 ` Philip Oakley
2016-04-25 22:14 ` Ramsay Jones [this message]
2016-04-26 13:19 ` Philip Oakley
2016-04-25 21:34 ` definition for _attribute() in remote.c Philip Oakley
2016-04-25 21:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E96CE.80606@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.