All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	felipe.balbi@linux.intel.com,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lee Jones <lee.jones@linaro.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface
Date: Tue, 26 Apr 2016 08:43:41 +0800	[thread overview]
Message-ID: <571EB9BD.2010502@linux.intel.com> (raw)
In-Reply-To: <571EAD88.5000505@samsung.com>

Hi,

On 04/26/2016 07:51 AM, Chanwoo Choi wrote:
> Hi Lu,
>
> On 2016년 04월 25일 17:04, Lu Baolu wrote:
>> GPIO resource could be retrieved through APCI as well.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Reviewed-by: Felipe Balbi <balbi@kernel.org>
>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  drivers/extcon/extcon-usb-gpio.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
>> index af9c8b0..472c431 100644
>> --- a/drivers/extcon/extcon-usb-gpio.c
>> +++ b/drivers/extcon/extcon-usb-gpio.c
>> @@ -26,6 +26,7 @@
>>  #include <linux/platform_device.h>
>>  #include <linux/slab.h>
>>  #include <linux/workqueue.h>
>> +#include <linux/acpi.h>
>>  
>>  #define USB_GPIO_DEBOUNCE_MS	20	/* ms */
>>  
>> @@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
>>  	struct usb_extcon_info *info;
>>  	int ret;
>>  
>> -	if (!np)
>> +	if (!np && !ACPI_HANDLE(dev))
>>  		return -EINVAL;
>>  
>>  	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
>>
> Applied it.
>
> Thanks,
> Chanwoo Choi
>

Thank you.

Best regards,
Baolu

>

  reply	other threads:[~2016-04-26  0:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25  8:04 [PATCH v6 00/10] usb: add support for Intel dual role port mux Lu Baolu
2016-04-25  8:04 ` [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device Lu Baolu
2016-04-25 23:51   ` Chanwoo Choi
2016-04-26  0:42     ` Lu Baolu
2016-04-25  8:04 ` [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu
2016-04-25 23:51   ` Chanwoo Choi
2016-04-26  0:43     ` Lu Baolu [this message]
2016-04-25  8:04 ` [PATCH v6 03/10] regulator: fixed: add device binding for platform device Lu Baolu
2016-04-25 16:40   ` Mark Brown
2016-04-26  2:12     ` Lu Baolu
2016-04-25  8:04 ` [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu
2016-04-25 17:30   ` Mark Brown
2016-04-26  2:24     ` Lu Baolu
2016-04-26 10:23       ` Mark Brown
2016-04-27  1:54         ` Lu Baolu
2016-04-27 12:33           ` Mark Brown
2016-04-28  5:55             ` Lu Baolu
2016-04-28 17:15               ` Mark Brown
2016-04-29  0:31                 ` Lu Baolu
2016-04-25  8:04 ` [PATCH v6 05/10] usb: mux: add generic code for dual role port mux Lu Baolu
2016-04-25  8:04 ` [PATCH v6 06/10] usb: mux: add driver for Intel gpio controlled " Lu Baolu
2016-04-25  8:04 ` [PATCH v6 07/10] usb: mux: add driver for Intel drcfg " Lu Baolu
2016-04-25  8:04 ` [PATCH v6 08/10] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu
2016-04-25  8:04 ` [PATCH v6 09/10] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu
2016-04-25  8:04 ` [PATCH v6 10/10] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571EB9BD.2010502@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.