From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbcDZDNQ (ORCPT ); Mon, 25 Apr 2016 23:13:16 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:34413 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbcDZDNN (ORCPT ); Mon, 25 Apr 2016 23:13:13 -0400 Subject: Re: next: suspicious RCU usage message since commit 'rcu: Remove superfluous versions of rcu_read_lock_sched_held()' To: paulmck@linux.vnet.ibm.com References: <20160424211424.GA20388@roeck-us.net> <20160424213147.GW3756@linux.vnet.ibm.com> <571D5D36.3060308@roeck-us.net> <20160425052847.GY3756@linux.vnet.ibm.com> <571DAD15.6070708@roeck-us.net> <20160425054922.GA3756@linux.vnet.ibm.com> <571DB8A1.7000704@roeck-us.net> <20160425171239.GE3874@linux.vnet.ibm.com> <20160425202510.GA7917@roeck-us.net> <20160425204921.GN3874@linux.vnet.ibm.com> Cc: Boqun Feng , Josh Triplett , Steven Rostedt , linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <571EDCC5.1080106@roeck-us.net> Date: Mon, 25 Apr 2016 20:13:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160425204921.GN3874@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/25/2016 01:49 PM, Paul E. McKenney wrote: > On Mon, Apr 25, 2016 at 01:25:10PM -0700, Guenter Roeck wrote: >> On Mon, Apr 25, 2016 at 10:12:39AM -0700, Paul E. McKenney wrote: >>> On Sun, Apr 24, 2016 at 11:26:41PM -0700, Guenter Roeck wrote: >>>> On 04/24/2016 10:49 PM, Paul E. McKenney wrote: >>>>> On Sun, Apr 24, 2016 at 10:37:25PM -0700, Guenter Roeck wrote: >>>>>> On 04/24/2016 10:28 PM, Paul E. McKenney wrote: >>>>>>> On Sun, Apr 24, 2016 at 04:56:38PM -0700, Guenter Roeck wrote: >>> >>> [ . . . ] >>> >>>>>>>> After making the same change in _pwrdm_state_switch(), the traceback is gone >>>>>>> >from my tests (beagle, beagle-xm, and overo-tobi). >>>>>>> >>>>>>> Very good! >>>>>>> >>>>>>> (And yes, you normally find these one at a time...) >>>>>>> >>>>>> Are you going to submit a formal patch ? >>>>> >>>>> I can, but please feel free to send mine along with yours, if you wish. >>>>> >>>> I think it would be best if you send a single patch which fixes both calls. >>> >>> Like this one? >>> >>> If so, could you please run it to make sure that it actually fixes the >>> problem? And if it does, would you be willing to give me a Tested-by? >>> >> It does. Tested-by: inline below. > > Got it, thank you! > > If the ARM guys are willing to take this, it might hit the next merge > window, or perhaps they will take it as an exception. If I push it > up my usual route, it will be a bit later. > > I just now sent it out, so hopefully they will grab it. ;-) > Hi Paul, Either it fixes a zero-day bug which was exposed by 'rcu: Remove superfluous versions ...", or it fixes a problem with that commit, so I would hope that _someone_ will pick it up. Anyway, thanks a lot for looking into it, and for the patch! Guenter