From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH 2/5] gvariant: Allow empty signature in enter_struct_dict_common
Date: Mon, 25 Apr 2016 23:01:14 -0500 [thread overview]
Message-ID: <571EE80A.2040105@gmail.com> (raw)
In-Reply-To: <1461373807-19793-3-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Hi Andrew,
On 04/22/2016 08:10 PM, Andrew Zaborowski wrote:
> gvariant_iter_init_internal now checks if the signature is empty before
> calling _gvariant_num_children which would return an error in that case.
> The gvariant_iter_init_internal caller is responsible for checking if
> the signature is allowed in the specific context.
> ---
> ell/gvariant-util.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
I went ahead an applied this one. But one question, what is the
practical utility of allowing iterators into the empty struct?
Regards,
-Denis
next prev parent reply other threads:[~2016-04-26 4:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 1:10 [PATCH] dbus: Handle kdbus KDBUS_ITEM_REPLY_TIMEOUT / _DEAD Andrew Zaborowski
2016-04-23 1:10 ` [PATCH 1/5] gvariant: _gvariant_num_children error check Andrew Zaborowski
2016-04-26 3:59 ` Denis Kenzior
2016-04-23 1:10 ` [PATCH 2/5] gvariant: Allow empty signature in enter_struct_dict_common Andrew Zaborowski
2016-04-26 4:01 ` Denis Kenzior [this message]
2016-04-26 9:08 ` Andrzej Zaborowski
2016-04-23 1:10 ` [PATCH 3/5] gvariant: Make sure builder outputs a zero for empty struct Andrew Zaborowski
2016-04-26 4:01 ` Denis Kenzior
2016-04-23 1:10 ` [PATCH 4/5] unit: Gvariant iterator and builder test for empty structs Andrew Zaborowski
2016-04-26 4:01 ` Denis Kenzior
2016-04-23 1:10 ` [PATCH 5/5] unit: Gvariant method call with no arguments tests Andrew Zaborowski
2016-04-26 4:02 ` Denis Kenzior
2016-04-26 3:49 ` [PATCH] dbus: Handle kdbus KDBUS_ITEM_REPLY_TIMEOUT / _DEAD Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571EE80A.2040105@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.