From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 1/5] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic Date: Tue, 26 Apr 2016 09:15:31 +0200 Message-ID: <571F1593.8000400@samsung.com> References: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1459801326-5541-2-git-send-email-ezequiel@vanguardiasur.com.ar> <20160424092551.GB23015@amd> <20160424092951.GA25596@amd> <571DBFAE.7060605@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:61342 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbcDZHPf (ORCPT ); Tue, 26 Apr 2016 03:15:35 -0400 In-reply-to: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Ezequiel Garcia Cc: Pavel Machek , Linux LED Subsystem , "linux-kernel@vger.kernel.org" , linux-arm-kernel , Richard Purdie Hi Ezequiel, On 04/25/2016 06:27 PM, Ezequiel Garcia wrote: > On 25 April 2016 at 03:56, Jacek Anaszewski wrote: >> On 04/24/2016 11:29 AM, Pavel Machek wrote: >>> >>> On Sun 2016-04-24 11:25:51, Pavel Machek wrote: >>>> >>>> On Mon 2016-04-04 17:22:02, Ezequiel Garcia wrote: >>>>> >>>>> This commit adds a new led_cdev flag LED_BLINK_AT_PANIC, which >>>>> allows to mark a specific LED to be switched to the "panic" >>>>> trigger, on a kernel panic. >>>>> >>>>> This is useful to allow the user to assign a regular trigger >>>>> to a given LED, and still blink that LED on a kernel panic. >>>>> >>>>> Signed-off-by: Ezequiel Garcia >>>> >>>> >>>> >>>>> drivers/leds/led-triggers.c | 52 >>>>> +++++++++++++++++++++++++++++++++++++++++++++ >>>>> include/linux/leds.h | 1 + >>>> >>>> >>>> Could we get this out of the core? I'm pretty sure most users are not >>>> interested... >> >> >> Good point. >> > > Not sure how we can get it out of the core, and still implement it. > > The goal is to run-time switch user-specified LEDs and blink them when > the kernel panics, and so it needs to mess up with some core private > structures. > > Unless we don't want this feature at all. > It seems that the entire added code can be easily moved to a separate module, let's say led-panic-notifier.c ? It should select LEDS_TRIGGER_PANIC, as it would make no sense to have the former enabled without the latter. -- Best regards, Jacek Anaszewski From mboxrd@z Thu Jan 1 00:00:00 1970 From: j.anaszewski@samsung.com (Jacek Anaszewski) Date: Tue, 26 Apr 2016 09:15:31 +0200 Subject: [PATCH 1/5] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic In-Reply-To: References: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1459801326-5541-2-git-send-email-ezequiel@vanguardiasur.com.ar> <20160424092551.GB23015@amd> <20160424092951.GA25596@amd> <571DBFAE.7060605@samsung.com> Message-ID: <571F1593.8000400@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Ezequiel, On 04/25/2016 06:27 PM, Ezequiel Garcia wrote: > On 25 April 2016 at 03:56, Jacek Anaszewski wrote: >> On 04/24/2016 11:29 AM, Pavel Machek wrote: >>> >>> On Sun 2016-04-24 11:25:51, Pavel Machek wrote: >>>> >>>> On Mon 2016-04-04 17:22:02, Ezequiel Garcia wrote: >>>>> >>>>> This commit adds a new led_cdev flag LED_BLINK_AT_PANIC, which >>>>> allows to mark a specific LED to be switched to the "panic" >>>>> trigger, on a kernel panic. >>>>> >>>>> This is useful to allow the user to assign a regular trigger >>>>> to a given LED, and still blink that LED on a kernel panic. >>>>> >>>>> Signed-off-by: Ezequiel Garcia >>>> >>>> >>>> >>>>> drivers/leds/led-triggers.c | 52 >>>>> +++++++++++++++++++++++++++++++++++++++++++++ >>>>> include/linux/leds.h | 1 + >>>> >>>> >>>> Could we get this out of the core? I'm pretty sure most users are not >>>> interested... >> >> >> Good point. >> > > Not sure how we can get it out of the core, and still implement it. > > The goal is to run-time switch user-specified LEDs and blink them when > the kernel panics, and so it needs to mess up with some core private > structures. > > Unless we don't want this feature at all. > It seems that the entire added code can be easily moved to a separate module, let's say led-panic-notifier.c ? It should select LEDS_TRIGGER_PANIC, as it would make no sense to have the former enabled without the latter. -- Best regards, Jacek Anaszewski