From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH] bond: inherit maximum rx packet length Date: Tue, 26 Apr 2016 11:51:53 +0100 Message-ID: <571F4849.5030509@intel.com> References: <1460654624-2066-1-git-send-email-ehkinzie@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Eric Kinzie , dev@dpdk.org Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A472A902 for ; Tue, 26 Apr 2016 12:55:33 +0200 (CEST) In-Reply-To: <1460654624-2066-1-git-send-email-ehkinzie@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/04/16 18:23, Eric Kinzie wrote: > Instead of a hard-coded maximum receive length, allow the bond interface > to inherit this limit from the first slave added. This allows > an application that uses jumbo frames to pass realistic values to > rte_eth_dev_configure without causing an error. > > Signed-off-by: Eric Kinzie > --- ... > Hey Eric, just one small thing, I think it probably makes sense to return the max rx pktlen for all slaves, so as we add each slave just check if that the slave being value is larger than the current value. @@ -385,6 +389,10 @@ __eth_bond_slave_add_lock_free(uint8_t bonded_port_id, uint8_t slave_port_id) internals->tx_offload_capa &= dev_info.tx_offload_capa; internals->flow_type_rss_offloads &= dev_info.flow_type_rss_offloads; + /* If new slave's max rx packet size is larger than current value then override */ + if (dev_info.max_rx_pktlen > internals->max_rx_pktlen) + internals->max_rx_pktlen = dev_info.max_rx_pktlen; + Declan