From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f53.google.com ([74.125.82.53]:33225 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbcDZMcM (ORCPT ); Tue, 26 Apr 2016 08:32:12 -0400 Received: by mail-wm0-f53.google.com with SMTP id g17so1573282wme.0 for ; Tue, 26 Apr 2016 05:32:12 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() References: <1461657978-13360-1-git-send-email-nicolas.dichtel@6wind.com> <1461657978-13360-4-git-send-email-nicolas.dichtel@6wind.com> <20160426110848.GD27612@quack2.suse.cz> To: Jan Kara Cc: netdev@vger.kernel.org, davem@davemloft.net, sd@queasysnail.net, johannes@sipsolutions.net, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, jack@suse.com, linux-kernel@vger.kernel.org, pshelar@nicira.com, dev@openvswitch.org, jhs@mojatatu.com, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, drbd-dev@lists.linbit.com From: Nicolas Dichtel Message-ID: <571F5FBE.8050900@6wind.com> (sfid-20160426_143243_818846_7E558881) Date: Tue, 26 Apr 2016 14:31:58 +0200 MIME-Version: 1.0 In-Reply-To: <20160426110848.GD27612@quack2.suse.cz> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: Le 26/04/2016 13:08, Jan Kara a écrit : > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote: >> Signed-off-by: Nicolas Dichtel > > OK, so I somewhat miss a description of what will this do to the netlink > message so that I can judge whether the change is fine for the userspace > counterpart parsing these messages. AFAIU this changes the message format > by adding a QUOTA_NL_A_PAD field before each 64-bit field which needs an > alignment, am I guessing right? Thus when the userspace counterpart uses > genlmsg_parse() it should just silently ignore these attributes if I read > the documentation right. Did I understand this correctly? Yes, that's it. Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com (zimbra.linbit.com [212.69.161.123]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id 49C561056446 for ; Tue, 26 Apr 2016 14:47:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id 3739B3F79D6 for ; Tue, 26 Apr 2016 14:47:50 +0200 (CEST) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 2UpeyI5K3O6O for ; Tue, 26 Apr 2016 14:47:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id 158A83F79D5 for ; Tue, 26 Apr 2016 14:47:50 +0200 (CEST) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8umvd2HblySn for ; Tue, 26 Apr 2016 14:47:49 +0200 (CEST) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra13.linbit.com (Postfix) with ESMTPS id CCFD53F79D3 for ; Tue, 26 Apr 2016 14:47:49 +0200 (CEST) Resent-Message-ID: <20160426124749.GM20950@soda.linbit> Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id A61C91056460 for ; Tue, 26 Apr 2016 14:39:46 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id u206so5123466wme.1 for ; Tue, 26 Apr 2016 05:39:46 -0700 (PDT) References: <1461657978-13360-1-git-send-email-nicolas.dichtel@6wind.com> <1461657978-13360-4-git-send-email-nicolas.dichtel@6wind.com> <20160426110848.GD27612@quack2.suse.cz> To: Jan Kara From: Nicolas Dichtel Message-ID: <571F5FBE.8050900@6wind.com> Date: Tue, 26 Apr 2016 14:31:58 +0200 MIME-Version: 1.0 In-Reply-To: <20160426110848.GD27612@quack2.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: dev@openvswitch.org, sd@queasysnail.net, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, jhs@mojatatu.com, pshelar@nicira.com, lars.ellenberg@linbit.com, jack@suse.com, johannes@sipsolutions.net, philipp.reisner@linbit.com, davem@davemloft.net, kvalo@codeaurora.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() Reply-To: nicolas.dichtel@6wind.com List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 26/04/2016 13:08, Jan Kara a =E9crit : > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote: >> Signed-off-by: Nicolas Dichtel >=20 > OK, so I somewhat miss a description of what will this do to the netlin= k > message so that I can judge whether the change is fine for the userspac= e > counterpart parsing these messages. AFAIU this changes the message form= at > by adding a QUOTA_NL_A_PAD field before each 64-bit field which needs a= n > alignment, am I guessing right? Thus when the userspace counterpart use= s > genlmsg_parse() it should just silently ignore these attributes if I re= ad > the documentation right. Did I understand this correctly? Yes, that's it. Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() Date: Tue, 26 Apr 2016 14:31:58 +0200 Message-ID: <571F5FBE.8050900@6wind.com> References: <1461657978-13360-1-git-send-email-nicolas.dichtel@6wind.com> <1461657978-13360-4-git-send-email-nicolas.dichtel@6wind.com> <20160426110848.GD27612@quack2.suse.cz> Reply-To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, sd-y1jBWg8GRStKuXlAQpz2QA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org, lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, jack-IBi9RG/b67k@public.gmane.org, johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org, philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Jan Kara Return-path: In-Reply-To: <20160426110848.GD27612-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org TGUgMjYvMDQvMjAxNiAxMzowOCwgSmFuIEthcmEgYSDDqWNyaXQgOgo+IE9uIFR1ZSAyNi0wNC0x NiAxMDowNjoxMywgTmljb2xhcyBEaWNodGVsIHdyb3RlOgo+PiBTaWduZWQtb2ZmLWJ5OiBOaWNv bGFzIERpY2h0ZWwgPG5pY29sYXMuZGljaHRlbEA2d2luZC5jb20+Cj4gCj4gT0ssIHNvIEkgc29t ZXdoYXQgbWlzcyBhIGRlc2NyaXB0aW9uIG9mIHdoYXQgd2lsbCB0aGlzIGRvIHRvIHRoZSBuZXRs aW5rCj4gbWVzc2FnZSBzbyB0aGF0IEkgY2FuIGp1ZGdlIHdoZXRoZXIgdGhlIGNoYW5nZSBpcyBm aW5lIGZvciB0aGUgdXNlcnNwYWNlCj4gY291bnRlcnBhcnQgcGFyc2luZyB0aGVzZSBtZXNzYWdl cy4gQUZBSVUgdGhpcyBjaGFuZ2VzIHRoZSBtZXNzYWdlIGZvcm1hdAo+IGJ5IGFkZGluZyBhIFFV T1RBX05MX0FfUEFEIGZpZWxkIGJlZm9yZSBlYWNoIDY0LWJpdCBmaWVsZCB3aGljaCBuZWVkcyBh bgo+IGFsaWdubWVudCwgYW0gSSBndWVzc2luZyByaWdodD8gVGh1cyB3aGVuIHRoZSB1c2Vyc3Bh Y2UgY291bnRlcnBhcnQgdXNlcwo+IGdlbmxtc2dfcGFyc2UoKSBpdCBzaG91bGQganVzdCBzaWxl bnRseSBpZ25vcmUgdGhlc2UgYXR0cmlidXRlcyBpZiBJIHJlYWQKPiB0aGUgZG9jdW1lbnRhdGlv biByaWdodC4gRGlkIEkgdW5kZXJzdGFuZCB0aGlzIGNvcnJlY3RseT8KWWVzLCB0aGF0J3MgaXQu CgoKUmVnYXJkcywKTmljb2xhcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkZXYgbWFpbGluZyBsaXN0CmRldkBvcGVudnN3aXRjaC5vcmcKaHR0cDovL29w ZW52c3dpdGNoLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Rldgo=