From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332: possible typo ?
Date: Tue, 26 Apr 2016 14:11:43 +0100 [thread overview]
Message-ID: <571F690F.90109@arm.com> (raw)
In-Reply-To: <DUB128-W495B590F6B8E0BF405721B9C620@phx.gbl>
On 25/04/16 21:31, David Binderman wrote:
> Hello there,
>
> linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332]: (style) Variable 'perf_stat_reg' is assigned a value that is never used.
>
> if (cluster_is_a15(cluster)) {
> req_type = CA15_DVFS;
> perf_cfg_reg = PERF_LVL_A15;
> perf_stat_reg = PERF_REQ_A15;
> } else {
> req_type = CA7_DVFS;
> perf_cfg_reg = PERF_LVL_A7;
> perf_stat_reg = PERF_REQ_A7;
> }
>
> But local variable perf_stat_reg doesn't get used anywhere.
>
> Suggest either delete or use.
>
You are always welcome to post the patch especially after all your
efforts to find it. Anyways I will post the patch for now.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-04-26 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 20:31 linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332: possible typo ? David Binderman
2016-04-26 13:11 ` Sudeep Holla [this message]
2016-04-26 13:11 ` [PATCH] ARM: vexpress/spc: remove unused variable perf_stat_reg Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571F690F.90109@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.