From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av6z8-00046M-4B for qemu-devel@nongnu.org; Tue, 26 Apr 2016 13:41:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av6z3-0005ZQ-Hy for qemu-devel@nongnu.org; Tue, 26 Apr 2016 13:41:18 -0400 References: <1461119601-4936-1-git-send-email-david@gibson.dropbear.id.au> <1461119601-4936-5-git-send-email-david@gibson.dropbear.id.au> From: Thomas Huth Message-ID: <571FA834.4000201@redhat.com> Date: Tue, 26 Apr 2016 19:41:08 +0200 MIME-Version: 1.0 In-Reply-To: <1461119601-4936-5-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC for-2.7 04/11] pseries: Make spapr_create_fdt_skel() get information from machine state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, crosthwaite.peter@gmail.com Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 20.04.2016 04:33, David Gibson wrote: > Currently spapr_create_fdt_skel() takes a bunch of individual parameters > for various things it will put in the device tree. Some of these can > already be taken directly from sPAPRMachineState. This patch alters it so > that all of them can be taken from there, which will allow this code to > be moved away from its current caller in future. > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 81 ++++++++++++++++++++++---------------------------- > include/hw/ppc/spapr.h | 4 +++ > 2 files changed, 40 insertions(+), 45 deletions(-) Reviewed-by: Thomas Huth