From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v1] ARM: clocksource: make ARM_GLOBAL_TIMER selectable Date: Tue, 26 Apr 2016 22:35:08 +0300 Message-ID: <571FC2EC.9090605@ti.com> References: <1461684532-16848-1-git-send-email-grygorii.strashko@ti.com> <20160426160245.GI28464@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160426160245.GI28464-2JSQmVVBSi7ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Liviu Dudau Cc: kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, Tony Lindgren , Sekhar Nori , Masahiro Yamada , Wei Xu , Jesper Nilsson , Florian Fainelli , Russell King , Daniel Lezcano , Michal Simek , linux-arm-kernel-VrBV9hrLPhE@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Arnd Bergmann , Mike Looijmans , Lars Persson , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Maxime Coquelin , Srinivas Kandagatla , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Sudeep Holla , Olof Johansson J List-Id: linux-omap@vger.kernel.org T24gMDQvMjYvMjAxNiAwNzowMiBQTSwgTGl2aXUgRHVkYXUgd3JvdGU6Cj4gT24gVHVlLCBBcHIg MjYsIDIwMTYgYXQgMDY6Mjg6NTJQTSArMDMwMCwgR3J5Z29yaWkgU3RyYXNoa28gd3JvdGU6Cj4g Cj4gSGkgR3J5Z29yaWksCj4gCj4gRmlyc3QgdGltZSBJJ20gc2VlaW5nIHRoaXMgcGF0Y2gsIHNv IEkgaGF2ZSBhIGZldyBxdWVzdGlvbnMsIG1vc3RseQo+IHJlbGF0ZWQgdG8gdGhlIGNvbW1pdCBt ZXNzYWdlOgoKSG0uIFlvdSBhcmUgaW4gY2MgZm9yIFJGQy4KU3J5LCBmb3Jnb3QgdG8gYWRkIGxp bmsgWzFdLgoKPiAKPj4gVGhpcyBwYXRjaCBpbnRlbmRlZCB0byBmaXggZm9sbG93aW5nIGNhc2Vz Ogo+PiAtIFNvQy1BIGhhcyBBUk0gR1QsIGRlZmluZXMgRFQgbm9kZSBmb3IgQVJNIEdUIGFuZCBz ZWxlY3RzCj4+IEFSTV9HTE9CQUxfVElNRVIgc3RhdGljYWxseSBpbiBLY29uZmlnIGZpbGUuIFNv Qy1CIGhhcyBBUk0gR1QgYW5kCj4+IGRlZmluZXMgRFQgbm9kZSBmb3IgQVJNIEdULCBidXQgZG8g bm90IHNlbGVjdHMgQVJNX0dMT0JBTF9USU1FUgo+PiBzdGF0aWNhbGx5IGluIEtjb25maWcgZmls ZS4gSW4gY2FzZSBvZiBtdWx0aXBsYXRmb3JtIGJ1aWxkIEFSTSBHVCB3aWxsCj4+IGJlIGltcGxp Y2l0bHkgZW5hYmxlZCBmb3IgU29DLUIuCj4gCj4gV2VsbCwgU29DLUIgaGFzIHRoZSBHVCAqYW5k KiB0aGUgRFQgbm9kZSwgc28gd2hhdCBpcyB0aGUgcHJvYmxlbSB3aXRoCj4gZW5hYmxpbmcgaXQg Zm9yIFNvQy1CPyBJZiB0aGVyZSBhcmUgcmVhc29ucyBub3QgdG8gdXNlIHRoZSBHbG9iYWwgVGlt ZXIKPiBvbiBTb0MtQiwgc3VyZWx5IGEgYmV0dGVyIG9wdGlvbiB3b3VsZCBiZSB0byBtYXJrIGl0 IGluIERUIHdpdGggc3RhdHVzID0gImRpc2FibGVkIjsKClRoaXMgd2FzIHJlamVjdGVkIFsyXS4g RFQgZGVzY3JpYmVzIEhXIGFuZCBpZiBpdCBpcyBmdW5jdGlvbmFsIHRoZSBzdGF0dXMgPSAiZGlz YWJsZWQiCmlzIG5vdCBnb29kIGNob2ljZS4KQVJNIEdUIGNhbid0IGJlIHVzZWQgYXMgY2xvY2tz b3VyY2Uvc2NoZWRfY2xvY2svY2xvY2tldmVudCB3aGVuIENQVUZyZXEgb3IKQ1BVSWRsZSBhcmUg ZW5hYmxlZCA6KCwgYW5kIHRoaXMgaXMgTGludXggc3BlY2lmaWMgZnVuY3Rpb25hbGl0eSBhbmQK bm90IEhXIGRlc2NyaXB0aW9uLiAKCj4gCj4+Cj4+IC0gVGhlcmUgaXMgbm8gd2F5IHRvIGRpc2Fi bGUgQVJNIEdUIHdpdGhvdXQgbW9kaWZ5aW5nIEtjb25maWcgZmlsZSwKPj4gb25jZSBBUk1fR0xP QkFMX1RJTUVSIGlzIHNlbGVjdGVkIHN0YXRpY2FsbHkgaW4gS2NvbmZpZyBmaWxlLgo+IAo+IFdo YXQgYWJvdXQgZGlzYWJsaW5nIHRoZSBEVCBub2RlPwo+IAo+IE5vdCBzdXJlIEkgcHJvcGVybHkg dW5kZXJzdGFuZCB0aGUgcHJvYmxlbSB5b3UgYXJlIHRyeWluZyB0byBzb2x2ZSBoZXJlLgoKSSdk IGxpa2UgdG8gaGF2ZSB3YXkgdG8gZW5hYmxlL2Rpc2FibGUgQVJNIEdUIHdpdGhvdXQgbW9kaWZ5 aW5nIEtlcm5lbCBzb3VyY2VzCihLY29uZmlnIHNwZWNpZmljYWxseSkgd2hpY2ggaXMgbm93IGlt cG9zc2libGUuCgo+IAo+Pgo+PiBIZW5jZSwgZml4IGFib3ZlIGNhc2UgYnkgZGVmaW5pbmcgYm90 aCBIQVZFX0FSTV9HTE9CQUxfVElNRVIgYW5kCj4+IEFSTV9HTE9CQUxfVElNRVIgYXMgcmVjb21t ZW5kZWQgYnkgJ0FkZGluZyBjb21tb24gZmVhdHVyZXMgYW5kIG1ha2UKPj4gdGhlIHVzYWdlIGNv bmZpZ3VyYWJsZScgc2VjdGlvbiBpbiBrY29uZmlnLWxhbmd1YWdlLnR4dC4gQWxsIHBsYWNlcyBp bgo+PiBBUk0gZm9sZGVyIHdoZXJlIEFSTV9HTE9CQUxfVElNRVIgd2FzIHVzZWQgbm93IHJlcGxh Y2VkIG9uCj4+IEhBVkVfQVJNX0dMT0JBTF9USU1FUi4KPiAKPiBJJ20gT0sgd2l0aCB0aGUgd2F5 IHlvdSBoYXZlIGNoYW5nZWQgQVJNX0dMT0JBTF9USU1FUiBmcm9tIGEgc3RpY2t5IGNvbmZpZwo+ IG9wdGlvbiB0byBhIHNlbGVjdGFibGUgb25lLCBidXQgSSB3b3VsZCBsaWtlIG1vcmUgZGV0YWls cyBvbiB0aGUgcHJvYmxlbQo+IHRoaXMgd2FzIGNhdXNpbmcgeW91Lgo+IAoKVGhlIHNhbWUgSFcg KGJvYXJkKSBjb3VsZCBiZSB1c2VkIHdpdGggUE0gZmVhdHVyZXMgZW5hYmxlZCAocG93ZXIgc2F2 aW5nKQphbmQgZGlzYWJsZWQgKC1SVCkuIFdpdGhvdXQgdGhpcyBjaGFuZ2UgaXQgd2lsbCByZXF1 aXJlIHRvIGhhdmUKYW5kIG1haW50YWluIHR3byBicmFuY2hlcywgYnV0IHdpdGggaXQgLSBqdXN0 IHNlcGFyYXRlIGRlZmNvbmZpZy4KClsxXSBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9waXBl cm1haWwvbGludXgtcm9ja2NoaXAvMjAxNi1GZWJydWFyeS8wMDcxNTkuaHRtbApbMl0gaHR0cDov L3d3dy5zcGluaWNzLm5ldC9saXN0cy9kZXZpY2V0cmVlL21zZzEwMjkxOC5odG1sCgo+IAo+Pgo+ PiBDYzogRGFuaWVsIExlemNhbm8gPGRhbmllbC5sZXpjYW5vQGxpbmFyby5vcmc+Cj4+IENjOiBG bG9yaWFuIEZhaW5lbGxpIDxmLmZhaW5lbGxpQGdtYWlsLmNvbT4KPj4gQ2M6IFJ1c3NlbGwgS2lu ZyA8bGludXhAYXJtLmxpbnV4Lm9yZy51az4KPj4gQ2M6IFdlaSBYdSA8eHV3ZWk1QGhpc2lsaWNv bi5jb20+Cj4+IENjOiBTaGF3biBHdW8gPHNoYXduZ3VvQGtlcm5lbC5vcmc+Cj4+IENjOiBTYXNj aGEgSGF1ZXIgPGtlcm5lbEBwZW5ndXRyb25peC5kZT4KPj4gQ2M6IFNyaW5pdmFzIEthbmRhZ2F0 bGEgPHNyaW5pdmFzLmthbmRhZ2F0bGFAZ21haWwuY29tPgo+PiBDYzogTWF4aW1lIENvcXVlbGlu IDxtYXhpbWUuY29xdWVsaW5Ac3QuY29tPgo+PiBDYzogTWFzYWhpcm8gWWFtYWRhIDx5YW1hZGEu bWFzYWhpcm9Ac29jaW9uZXh0LmNvbT4KPj4gQ2M6IExpdml1IER1ZGF1IDxsaXZpdS5kdWRhdUBh cm0uY29tPgo+PiBDYzogU3VkZWVwIEhvbGxhIDxzdWRlZXAuaG9sbGFAYXJtLmNvbT4KPj4gQ2M6 IEp1biBOaWUgPGp1bi5uaWVAbGluYXJvLm9yZz4KPj4gQ2M6IE1pY2hhbCBTaW1layA8bWljaGFs LnNpbWVrQHhpbGlueC5jb20+Cj4+IENjOiBKZXNwZXIgTmlsc3NvbiA8amVzcGVyLm5pbHNzb25A YXhpcy5jb20+Cj4+IENjOiBMYXJzIFBlcnNzb24gPGxhcnMucGVyc3NvbkBheGlzLmNvbT4KPj4g Q2M6IE1pa2UgTG9vaWptYW5zIDxtaWtlLmxvb2lqbWFuc0B0b3BpYy5ubD4KPj4gQWNrZWQtYnk6 IFPDtnJlbiBCcmlua21hbm4gPHNvcmVuLmJyaW5rbWFubkB4aWxpbnguY29tPgo+PiBBY2tlZC1i eTogTW9yaXR6IEZpc2NoZXIgPG1vcml0ei5maXNjaGVyQGV0dHVzLmNvbT4KPj4gU2lnbmVkLW9m Zi1ieTogR3J5Z29yaWkgU3RyYXNoa28gPGdyeWdvcmlpLnN0cmFzaGtvQHRpLmNvbT4KPj4gLS0t Cj4+IENoYW5nZXMgaXMgdjE6Cj4+IC0gdXBkYXRlZCBtYWNoLWFydHBlYwo+PiAtIHJlYmFzZWQg b24gdG9wIG9mIHRpcDogdGltZXJzL2NvcmUKPj4gICAgY29tbWl0OiA4NmQzNDczIHRpbWU6IElu dHJvZHVjZSBkb19zeXNfc2V0dGltZW9mZGF5NjQoKQo+Pgo+PiAgIGFyY2gvYXJtL21hY2gtYXJ0 cGVjL0tjb25maWcgICB8IDIgKy0KPj4gICBhcmNoL2FybS9tYWNoLWJjbS9LY29uZmlnICAgICAg fCA0ICsrLS0KPj4gICBhcmNoL2FybS9tYWNoLWhpc2kvS2NvbmZpZyAgICAgfCAyICstCj4+ICAg YXJjaC9hcm0vbWFjaC1pbXgvS2NvbmZpZyAgICAgIHwgMiArLQo+PiAgIGFyY2gvYXJtL21hY2gt cm9ja2NoaXAvS2NvbmZpZyB8IDIgKy0KPj4gICBhcmNoL2FybS9tYWNoLXN0aS9LY29uZmlnICAg ICAgfCAyICstCj4+ICAgYXJjaC9hcm0vbWFjaC11bmlwaGllci9LY29uZmlnIHwgMiArLQo+PiAg IGFyY2gvYXJtL21hY2gtdmV4cHJlc3MvS2NvbmZpZyB8IDIgKy0KPj4gICBhcmNoL2FybS9tYWNo LXp4L0tjb25maWcgICAgICAgfCAyICstCj4+ICAgYXJjaC9hcm0vbWFjaC16eW5xL0tjb25maWcg ICAgIHwgMiArLQo+PiAgIGRyaXZlcnMvY2xvY2tzb3VyY2UvS2NvbmZpZyAgICB8IDcgKysrKysr LQo+PiAgIDExIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygt KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1hcnRwZWMvS2NvbmZpZyBiL2FyY2gv YXJtL21hY2gtYXJ0cGVjL0tjb25maWcKPj4gaW5kZXggNmNiZTVhMi4uNmNiY2E3NyAxMDA2NDQK Pj4gLS0tIGEvYXJjaC9hcm0vbWFjaC1hcnRwZWMvS2NvbmZpZwo+PiArKysgYi9hcmNoL2FybS9t YWNoLWFydHBlYy9LY29uZmlnCj4+IEBAIC05LDcgKzksNyBAQCBjb25maWcgTUFDSF9BUlRQRUM2 Cj4+ICAgCWRlcGVuZHMgb24gQVJDSF9NVUxUSV9WNwo+PiAgIAlzZWxlY3QgQVJNX0FNQkEKPj4g ICAJc2VsZWN0IEFSTV9HSUMKPj4gLQlzZWxlY3QgQVJNX0dMT0JBTF9USU1FUgoKWy4uLl0KCi0t IApyZWdhcmRzLAotZ3J5Z29yaWkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Tue, 26 Apr 2016 22:35:08 +0300 Subject: [PATCH v1] ARM: clocksource: make ARM_GLOBAL_TIMER selectable In-Reply-To: <20160426160245.GI28464@e106497-lin.cambridge.arm.com> References: <1461684532-16848-1-git-send-email-grygorii.strashko@ti.com> <20160426160245.GI28464@e106497-lin.cambridge.arm.com> Message-ID: <571FC2EC.9090605@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/26/2016 07:02 PM, Liviu Dudau wrote: > On Tue, Apr 26, 2016 at 06:28:52PM +0300, Grygorii Strashko wrote: > > Hi Grygorii, > > First time I'm seeing this patch, so I have a few questions, mostly > related to the commit message: Hm. You are in cc for RFC. Sry, forgot to add link [1]. > >> This patch intended to fix following cases: >> - SoC-A has ARM GT, defines DT node for ARM GT and selects >> ARM_GLOBAL_TIMER statically in Kconfig file. SoC-B has ARM GT and >> defines DT node for ARM GT, but do not selects ARM_GLOBAL_TIMER >> statically in Kconfig file. In case of multiplatform build ARM GT will >> be implicitly enabled for SoC-B. > > Well, SoC-B has the GT *and* the DT node, so what is the problem with > enabling it for SoC-B? If there are reasons not to use the Global Timer > on SoC-B, surely a better option would be to mark it in DT with status = "disabled"; This was rejected [2]. DT describes HW and if it is functional the status = "disabled" is not good choice. ARM GT can't be used as clocksource/sched_clock/clockevent when CPUFreq or CPUIdle are enabled :(, and this is Linux specific functionality and not HW description. > >> >> - There is no way to disable ARM GT without modifying Kconfig file, >> once ARM_GLOBAL_TIMER is selected statically in Kconfig file. > > What about disabling the DT node? > > Not sure I properly understand the problem you are trying to solve here. I'd like to have way to enable/disable ARM GT without modifying Kernel sources (Kconfig specifically) which is now impossible. > >> >> Hence, fix above case by defining both HAVE_ARM_GLOBAL_TIMER and >> ARM_GLOBAL_TIMER as recommended by 'Adding common features and make >> the usage configurable' section in kconfig-language.txt. All places in >> ARM folder where ARM_GLOBAL_TIMER was used now replaced on >> HAVE_ARM_GLOBAL_TIMER. > > I'm OK with the way you have changed ARM_GLOBAL_TIMER from a sticky config > option to a selectable one, but I would like more details on the problem > this was causing you. > The same HW (board) could be used with PM features enabled (power saving) and disabled (-RT). Without this change it will require to have and maintain two branches, but with it - just separate defconfig. [1] http://lists.infradead.org/pipermail/linux-rockchip/2016-February/007159.html [2] http://www.spinics.net/lists/devicetree/msg102918.html > >> >> Cc: Daniel Lezcano >> Cc: Florian Fainelli >> Cc: Russell King >> Cc: Wei Xu >> Cc: Shawn Guo >> Cc: Sascha Hauer >> Cc: Srinivas Kandagatla >> Cc: Maxime Coquelin >> Cc: Masahiro Yamada >> Cc: Liviu Dudau >> Cc: Sudeep Holla >> Cc: Jun Nie >> Cc: Michal Simek >> Cc: Jesper Nilsson >> Cc: Lars Persson >> Cc: Mike Looijmans >> Acked-by: S?ren Brinkmann >> Acked-by: Moritz Fischer >> Signed-off-by: Grygorii Strashko >> --- >> Changes is v1: >> - updated mach-artpec >> - rebased on top of tip: timers/core >> commit: 86d3473 time: Introduce do_sys_settimeofday64() >> >> arch/arm/mach-artpec/Kconfig | 2 +- >> arch/arm/mach-bcm/Kconfig | 4 ++-- >> arch/arm/mach-hisi/Kconfig | 2 +- >> arch/arm/mach-imx/Kconfig | 2 +- >> arch/arm/mach-rockchip/Kconfig | 2 +- >> arch/arm/mach-sti/Kconfig | 2 +- >> arch/arm/mach-uniphier/Kconfig | 2 +- >> arch/arm/mach-vexpress/Kconfig | 2 +- >> arch/arm/mach-zx/Kconfig | 2 +- >> arch/arm/mach-zynq/Kconfig | 2 +- >> drivers/clocksource/Kconfig | 7 ++++++- >> 11 files changed, 17 insertions(+), 12 deletions(-) >> >> diff --git a/arch/arm/mach-artpec/Kconfig b/arch/arm/mach-artpec/Kconfig >> index 6cbe5a2..6cbca77 100644 >> --- a/arch/arm/mach-artpec/Kconfig >> +++ b/arch/arm/mach-artpec/Kconfig >> @@ -9,7 +9,7 @@ config MACH_ARTPEC6 >> depends on ARCH_MULTI_V7 >> select ARM_AMBA >> select ARM_GIC >> - select ARM_GLOBAL_TIMER [...] -- regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117AbcDZThz (ORCPT ); Tue, 26 Apr 2016 15:37:55 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:59636 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752976AbcDZTh1 (ORCPT ); Tue, 26 Apr 2016 15:37:27 -0400 Subject: Re: [PATCH v1] ARM: clocksource: make ARM_GLOBAL_TIMER selectable To: Liviu Dudau References: <1461684532-16848-1-git-send-email-grygorii.strashko@ti.com> <20160426160245.GI28464@e106497-lin.cambridge.arm.com> CC: Daniel Lezcano , Arnd Bergmann , Olof Johansson , , Sekhar Nori , , Tony Lindgren , , , , , , Florian Fainelli , Russell King , Wei Xu , Shawn Guo , Sascha Hauer , Srinivas Kandagatla , Maxime Coquelin , Masahiro Yamada , Sudeep Holla , Jun Nie , Michal Simek , Jesper Nilsson , Lars Persson , Mike Looijmans From: Grygorii Strashko Message-ID: <571FC2EC.9090605@ti.com> Date: Tue, 26 Apr 2016 22:35:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160426160245.GI28464@e106497-lin.cambridge.arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2016 07:02 PM, Liviu Dudau wrote: > On Tue, Apr 26, 2016 at 06:28:52PM +0300, Grygorii Strashko wrote: > > Hi Grygorii, > > First time I'm seeing this patch, so I have a few questions, mostly > related to the commit message: Hm. You are in cc for RFC. Sry, forgot to add link [1]. > >> This patch intended to fix following cases: >> - SoC-A has ARM GT, defines DT node for ARM GT and selects >> ARM_GLOBAL_TIMER statically in Kconfig file. SoC-B has ARM GT and >> defines DT node for ARM GT, but do not selects ARM_GLOBAL_TIMER >> statically in Kconfig file. In case of multiplatform build ARM GT will >> be implicitly enabled for SoC-B. > > Well, SoC-B has the GT *and* the DT node, so what is the problem with > enabling it for SoC-B? If there are reasons not to use the Global Timer > on SoC-B, surely a better option would be to mark it in DT with status = "disabled"; This was rejected [2]. DT describes HW and if it is functional the status = "disabled" is not good choice. ARM GT can't be used as clocksource/sched_clock/clockevent when CPUFreq or CPUIdle are enabled :(, and this is Linux specific functionality and not HW description. > >> >> - There is no way to disable ARM GT without modifying Kconfig file, >> once ARM_GLOBAL_TIMER is selected statically in Kconfig file. > > What about disabling the DT node? > > Not sure I properly understand the problem you are trying to solve here. I'd like to have way to enable/disable ARM GT without modifying Kernel sources (Kconfig specifically) which is now impossible. > >> >> Hence, fix above case by defining both HAVE_ARM_GLOBAL_TIMER and >> ARM_GLOBAL_TIMER as recommended by 'Adding common features and make >> the usage configurable' section in kconfig-language.txt. All places in >> ARM folder where ARM_GLOBAL_TIMER was used now replaced on >> HAVE_ARM_GLOBAL_TIMER. > > I'm OK with the way you have changed ARM_GLOBAL_TIMER from a sticky config > option to a selectable one, but I would like more details on the problem > this was causing you. > The same HW (board) could be used with PM features enabled (power saving) and disabled (-RT). Without this change it will require to have and maintain two branches, but with it - just separate defconfig. [1] http://lists.infradead.org/pipermail/linux-rockchip/2016-February/007159.html [2] http://www.spinics.net/lists/devicetree/msg102918.html > >> >> Cc: Daniel Lezcano >> Cc: Florian Fainelli >> Cc: Russell King >> Cc: Wei Xu >> Cc: Shawn Guo >> Cc: Sascha Hauer >> Cc: Srinivas Kandagatla >> Cc: Maxime Coquelin >> Cc: Masahiro Yamada >> Cc: Liviu Dudau >> Cc: Sudeep Holla >> Cc: Jun Nie >> Cc: Michal Simek >> Cc: Jesper Nilsson >> Cc: Lars Persson >> Cc: Mike Looijmans >> Acked-by: Sören Brinkmann >> Acked-by: Moritz Fischer >> Signed-off-by: Grygorii Strashko >> --- >> Changes is v1: >> - updated mach-artpec >> - rebased on top of tip: timers/core >> commit: 86d3473 time: Introduce do_sys_settimeofday64() >> >> arch/arm/mach-artpec/Kconfig | 2 +- >> arch/arm/mach-bcm/Kconfig | 4 ++-- >> arch/arm/mach-hisi/Kconfig | 2 +- >> arch/arm/mach-imx/Kconfig | 2 +- >> arch/arm/mach-rockchip/Kconfig | 2 +- >> arch/arm/mach-sti/Kconfig | 2 +- >> arch/arm/mach-uniphier/Kconfig | 2 +- >> arch/arm/mach-vexpress/Kconfig | 2 +- >> arch/arm/mach-zx/Kconfig | 2 +- >> arch/arm/mach-zynq/Kconfig | 2 +- >> drivers/clocksource/Kconfig | 7 ++++++- >> 11 files changed, 17 insertions(+), 12 deletions(-) >> >> diff --git a/arch/arm/mach-artpec/Kconfig b/arch/arm/mach-artpec/Kconfig >> index 6cbe5a2..6cbca77 100644 >> --- a/arch/arm/mach-artpec/Kconfig >> +++ b/arch/arm/mach-artpec/Kconfig >> @@ -9,7 +9,7 @@ config MACH_ARTPEC6 >> depends on ARCH_MULTI_V7 >> select ARM_AMBA >> select ARM_GIC >> - select ARM_GLOBAL_TIMER [...] -- regards, -grygorii