From: Florian Fainelli <f.fainelli@gmail.com>
To: Timur Tabi <timur@codeaurora.org>,
netdev@vger.kernel.org, davem@davemloft.net,
marek.belisko@gmail.com, ujhelyi.m@gmail.com, zonque@gmail.com
Subject: Re: [PATCH] net: phy: at803x: only the AT8030 needs a hardware reset on link change
Date: Tue, 26 Apr 2016 19:46:09 -0700 [thread overview]
Message-ID: <572027F1.9000009@gmail.com> (raw)
In-Reply-To: <1461692658-1742-1-git-send-email-timur@codeaurora.org>
Le 26/04/2016 10:44, Timur Tabi a écrit :
> Commit 13a56b44 ("at803x: Add support for hardware reset") added a
> work-around for a hardware bug on the AT8030. However, the work-around
> was being called for all 803x PHYs, even those that don't need it.
> Function at803x_link_change_notify() checks to make sure that it only
> resets the PHY on the 8030, but it makes more sense to not call that
> function at all if it isn't needed.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
This looks nicer indeed!
--
Florian
next prev parent reply other threads:[~2016-04-27 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 17:44 [PATCH] net: phy: at803x: only the AT8030 needs a hardware reset on link change Timur Tabi
2016-04-27 2:46 ` Florian Fainelli [this message]
2016-04-28 20:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572027F1.9000009@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=marek.belisko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=ujhelyi.m@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.