From: "Wangnan (F)" <wangnan0@huawei.com>
To: Florian Fainelli <f.fainelli@gmail.com>, <linux-kernel@vger.kernel.org>
Cc: <ast@kernel.org>, <jolsa@kernel.org>, <acme@redhat.com>
Subject: Re: [PATCH 1/2] bfp tools: Remove expression with no effect
Date: Wed, 27 Apr 2016 11:11:26 +0800 [thread overview]
Message-ID: <57202DDE.8090200@huawei.com> (raw)
In-Reply-To: <1461551694-5512-2-git-send-email-f.fainelli@gmail.com>
On 2016/4/25 10:34, Florian Fainelli wrote:
> Assigning "attr" to "attr" does not have any effect, but was caught by
> Coverity, so let's remove this.
>
> Reported-by: coverity (CID 1354720)
> Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> tools/build/feature/test-bpf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
> index b389026839b9..8236df9a46ca 100644
> --- a/tools/build/feature/test-bpf.c
> +++ b/tools/build/feature/test-bpf.c
> @@ -27,7 +27,6 @@ int main(void)
> attr.log_level = 0;
> attr.kern_version = 0;
>
> - attr = attr;
> /*
> * Test existence of __NR_bpf and BPF_PROG_LOAD.
> * This call should fail if we run the testcase.
Tested-by: Wang Nan <wangnan0@huawei.com>
next prev parent reply other threads:[~2016-04-27 3:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 2:34 [PATCH 0/2] bfp tools: Couple Coverity fixes Florian Fainelli
2016-04-25 2:34 ` [PATCH 1/2] bfp tools: Remove expression with no effect Florian Fainelli
2016-04-27 3:11 ` Wangnan (F) [this message]
2016-04-27 14:33 ` Arnaldo Carvalho de Melo
2016-05-01 7:36 ` [tip:perf/core] bpf " tip-bot for Florian Fainelli
2016-04-25 2:34 ` [PATCH 2/2] bfp tools: Fix syscall argument Florian Fainelli
2016-04-27 3:01 ` Wangnan (F)
2016-04-27 14:34 ` Arnaldo Carvalho de Melo
2016-05-01 7:37 ` [tip:perf/core] bpf " tip-bot for Florian Fainelli
2016-04-27 2:46 ` [PATCH 0/2] bfp tools: Couple Coverity fixes Florian Fainelli
2016-04-27 3:00 ` Wangnan (F)
2016-04-27 3:08 ` Alexei Starovoitov
2016-04-27 14:24 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57202DDE.8090200@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@redhat.com \
--cc=ast@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.