From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: xfs: add necessary version check for xfs/122
Date: Wed, 27 Apr 2016 12:55:07 +0800 [thread overview]
Message-ID: <5720462B.4050900@cn.fujitsu.com> (raw)
In-Reply-To: <20160322225614.GW11812@dastard>
hello,
On 03/23/2016 06:56 AM, Dave Chinner wrote:
> On Mon, Mar 21, 2016 at 04:31:28PM +0800, Xiaoguang Wang wrote:
>> From: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
>>
>> Since commit c0cfa5651f2d ("xfs/122: update against xfsprogs 4.3"), xfs/122
>> has been updated against xfsprogs 4.3, so add necessary version check.
>>
>> Signed-off-by: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
>
> This sort of version test belongs in autoconf, not the tests
> themselves.
Would you please give me some hints about how to add version test
in autoconf, also in xfs/188, I see similar usage:
if [ $XFSPROGS_VERSION -lt 21000 ]; then
_notrun "this test requires case-insensitive support"
fi
Regards,
Xiaoguang Wang
>
> Cheers,
>
> Dave.
>
next prev parent reply other threads:[~2016-04-27 5:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 8:31 [PATCH] fstests: xfs: add necessary version check for xfs/122 Xiaoguang Wang
2016-03-22 22:56 ` Dave Chinner
2016-04-27 4:55 ` Xiaoguang Wang [this message]
2016-04-29 1:05 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720462B.4050900@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.