From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:38466 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203AbcD0H30 (ORCPT ); Wed, 27 Apr 2016 03:29:26 -0400 Received: by mail-wm0-f44.google.com with SMTP id u206so35704581wme.1 for ; Wed, 27 Apr 2016 00:29:25 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit References: <1461339084-3849-1-git-send-email-nicolas.dichtel@6wind.com> <1461339084-3849-10-git-send-email-nicolas.dichtel@6wind.com> <57201287.80002@gmail.com> From: Nicolas Dichtel Message-ID: <57206A47.2010906@6wind.com> Date: Wed, 27 Apr 2016 09:29:11 +0200 MIME-Version: 1.0 In-Reply-To: <57201287.80002@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Balbir Singh , netdev@vger.kernel.org Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org, aar@pengutronix.de, pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, dev@openvswitch.org, steffen.klassert@secunet.com, herbert@gondor.apana.org.au Le 27/04/2016 03:14, Balbir Singh a écrit : > > > On 23/04/16 01:31, Nicolas Dichtel wrote: >> Goal of this patch is to use the new libnl API to align netlink attribute >> when needed. >> The layout of the netlink message will be a bit different after the patch, >> because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested >> attribute instead of before it. >> >> Signed-off-by: Nicolas Dichtel > > The layout will change/break user space -- I've not tested the patch though.. Sigh. I quote David: "All userspace components using netlink should always ignore attributes they do not recognize in dumps. This is one of the most basic principles of netlink" Do you have some pointers so I can made some tests? Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit Date: Wed, 27 Apr 2016 09:29:11 +0200 Message-ID: <57206A47.2010906@6wind.com> References: <1461339084-3849-1-git-send-email-nicolas.dichtel@6wind.com> <1461339084-3849-10-git-send-email-nicolas.dichtel@6wind.com> <57201287.80002@gmail.com> Reply-To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org, kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org, jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org, linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org, pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org To: Balbir Singh , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <57201287.80002-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netfilter-devel.vger.kernel.org TGUgMjcvMDQvMjAxNiAwMzoxNCwgQmFsYmlyIFNpbmdoIGEgw6ljcml0IDoKPiAKPiAKPiBPbiAy My8wNC8xNiAwMTozMSwgTmljb2xhcyBEaWNodGVsIHdyb3RlOgo+PiBHb2FsIG9mIHRoaXMgcGF0 Y2ggaXMgdG8gdXNlIHRoZSBuZXcgbGlibmwgQVBJIHRvIGFsaWduIG5ldGxpbmsgYXR0cmlidXRl Cj4+IHdoZW4gbmVlZGVkLgo+PiBUaGUgbGF5b3V0IG9mIHRoZSBuZXRsaW5rIG1lc3NhZ2Ugd2ls bCBiZSBhIGJpdCBkaWZmZXJlbnQgYWZ0ZXIgdGhlIHBhdGNoLAo+PiBiZWNhdXNlIHRoZSBwYWRh dHRyIChUQVNLU1RBVFNfVFlQRV9TVEFUUykgd2lsbCBiZSBpbnNpZGUgdGhlIG5lc3RlZAo+PiBh dHRyaWJ1dGUgaW5zdGVhZCBvZiBiZWZvcmUgaXQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE5pY29s YXMgRGljaHRlbCA8bmljb2xhcy5kaWNodGVsQDZ3aW5kLmNvbT4KPiAKPiBUaGUgbGF5b3V0IHdp bGwgY2hhbmdlL2JyZWFrIHVzZXIgc3BhY2UgLS0gSSd2ZSBub3QgdGVzdGVkIHRoZSBwYXRjaCB0 aG91Z2guLgpTaWdoLgoKSSBxdW90ZSBEYXZpZDoKIkFsbCB1c2Vyc3BhY2UgY29tcG9uZW50cyB1 c2luZyBuZXRsaW5rIHNob3VsZCBhbHdheXMgaWdub3JlIGF0dHJpYnV0ZXMKdGhleSBkbyBub3Qg cmVjb2duaXplIGluIGR1bXBzLgoKVGhpcyBpcyBvbmUgb2YgdGhlIG1vc3QgYmFzaWMgcHJpbmNp cGxlcyBvZiBuZXRsaW5rIgoKRG8geW91IGhhdmUgc29tZSBwb2ludGVycyBzbyBJIGNhbiBtYWRl IHNvbWUgdGVzdHM/CgoKUmVnYXJkcywKTmljb2xhcwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkZXYgbWFpbGluZyBsaXN0CmRldkBvcGVudnN3aXRjaC5v cmcKaHR0cDovL29wZW52c3dpdGNoLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Rldgo=