From: "Benoît Mauduit" <bmauduit@beneth.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] kodi: Enable raspberry-pi2 build support
Date: Wed, 27 Apr 2016 11:08:56 +0200 [thread overview]
Message-ID: <572081A8.7060506@beneth.fr> (raw)
In-Reply-To: <8415vcxn9i.ln2@ID-313208.user.individual.net>
Hi all,
On 04/26/2016 10:54 PM, Bernd Kuhls wrote:
> Am Tue, 26 Apr 2016 22:32:56 +0200 schrieb Thomas Petazzoni:
>
>> Hello,
>>
>> On Tue, 26 Apr 2016 22:21:14 +0200, Beno?t Mauduit wrote:
>>> The previous commit [ef37472b20894c99cad758397f3cd6b90f933df1] was
>>> based on a newer version of Kodi :
>>> "with-platform=raspberry-pi2" is not yet supported in Kodi "Jarvis"
> branch.
>>>
>>> Backport 2 patches from Kodi master branch into this one.
>>>
>>> Signed-off-by: Beno?t Mauduit <bmauduit@beneth.fr>
>>
>> Thanks. I do remember seeing a report (on IRC ?) that commit
>> ef37472b20894c99cad758397f3cd6b90f933df1 was indeed causing some
>> problems.
>>
>> Yann, Bernd, can you review/ack this patch from Beno?t?
>
> Hi Thomas,
>
> reviewing it will be difficult for me because I can not do a runtime test
> because I do not have access to RPI hardware.
>
> Currently I am preparing a patch series for the 17.0-Krypton version
> bump, I think I will send the first part of it to my github account in
> the coming days after some of my PR for the Kodi project are completed.
>
> Backporting feature patches is, afair, something you do not really like ;)
> As always, as a normal Kodi user, I do not know any release dates but
> 17.0-Krypton did not even reach alpha1 yet so expect several months until
> the next version is released. Maybe we should wait for it nonetheless?
Sorry to ask this, but do you have an explanation about not taking
upstream patches ? It is not obvious for me.
Also, I began to implement this fix on my own, and after seeing that
master branch have implemented this, I thought that it would better to
backport it. (Plus some addition from my side, that I will try to report
upstream).
From my point of view, we can integrate this patch (affecting only
raspberry-pi2 build) and remove it when the newer version of Kodi will
integrate it ?
Anyway, thanks for your feedbacks !
Regards,
Ps: I have tested Kodi on my raspberry-pi2. It works like a charm :)
--
Beno?t Mauduit
Mail : <bmauduit@beneth.fr>
XMPP : <bmauduit@im.beneth.fr>
next prev parent reply other threads:[~2016-04-27 9:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 20:21 [Buildroot] [PATCH 1/1] kodi: Enable raspberry-pi2 build support Benoît Mauduit
2016-04-26 20:32 ` Thomas Petazzoni
2016-04-26 20:54 ` Bernd Kuhls
2016-04-27 9:08 ` Benoît Mauduit [this message]
2016-05-08 7:38 ` Yann E. MORIN
2016-04-26 21:00 ` Yann E. MORIN
2016-05-07 20:50 ` Thomas Petazzoni
2016-05-08 7:38 ` Yann E. MORIN
2016-05-12 13:06 ` Benoît Mauduit
2016-05-12 17:26 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572081A8.7060506@beneth.fr \
--to=bmauduit@beneth.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.