From mboxrd@z Thu Jan  1 00:00:00 1970
From: marex@denx.de (Marek Vasut)
Date: Wed, 27 Apr 2016 16:45:19 +0200
Subject: [PATCH] ARM: dts: imx28-m28: Fix unit-address for partitions
In-Reply-To: <1461765754-19020-1-git-send-email-fabio.estevam@nxp.com>
References: <1461765754-19020-1-git-send-email-fabio.estevam@nxp.com>
Message-ID: <5720D07F.2040309@denx.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 04/27/2016 04:02 PM, Fabio Estevam wrote:
> According to ePAPR v1.1: "The unit-address must match the first address
> specified in the reg property of the node"
> 
> So do as recommended.

Looks good, but if I may, I would suggest something more drastic.
Would you instead remove the whole partitioning from the M28 DT?
We always pass mtdparts from command line, so having some sort of
default partitioning is quite pointless.

Thanks for spotting this though, it's a good reminder to review
older boards.

> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/boot/dts/imx28-m28.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-m28.dtsi b/arch/arm/boot/dts/imx28-m28.dtsi
> index 759cc56..6270701 100644
> --- a/arch/arm/boot/dts/imx28-m28.dtsi
> +++ b/arch/arm/boot/dts/imx28-m28.dtsi
> @@ -34,22 +34,22 @@
>  					read-only;
>  				};
>  
> -				partition at 1 {
> +				partition at 300000 {
>  					label = "environment";
>  					reg = <0x00300000 0x00080000>;
>  				};
>  
> -				partition at 2 {
> +				partition at 380000 {
>  					label = "redundant-environment";
>  					reg = <0x00380000 0x00080000>;
>  				};
>  
> -				partition at 3 {
> +				partition at 400000 {
>  					label = "kernel";
>  					reg = <0x00400000 0x00400000>;
>  				};
>  
> -				partition at 4 {
> +				partition at 800000 {
>  					label = "filesystem";
>  					reg = <0x00800000 0x0f800000>;
>  				};
> 


-- 
Best regards,
Marek Vasut