Re: [PATCH v3 1/3] gssd: use pthreads to handle upcalls

[Steve Dickson <SteveD@redhat.com>]

On 04/27/2016 12:33 PM, Kornievskaia, Olga wrote:
>>>> I think the biggest saving would be to take the next step 
>>>> and do the pool of threads that are pre-created (and thus 
>>>> not taking time to be allocated for each upcall). Then we 
>>>> need a way to make sure we cleanup any threads that might 
>>>> be hanging for whatever reason.
>>> This will be an excellent next step! 
>>
>> This patch series is suppose to show ‘proof-of-concept’ and 
>> functionally equivalent but better to what we have now. 
>> Old: upcall -> new process. New: upcall -> new thread. 
>> Old: process hangs -> resources not cleaned and no new upcalls. 
>> New: thread hangs -> resources not cleaned and new upcalls can proceed.
Well I think you proved it... Nice work!

>>
>> I will submit the new version with:
>> — make function inline
>> — change setresuid/setresgid to set all three uids: real, effective, saved. git blame tells me Jeff you wrote the comment about attacks from ptrace().
> 
> Sorry I unintentionally hit send. I wanted to say that then I’ll work on 
> getting the pool of thread but working on top of these patches. 
> Or do you want me to keep working and then submit that version 
> as if this one wasn’t written? 
Let's get these in now so they will get some real world 
testing... So lets build on these... 

steved.