From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avUyX-0003ED-DD for qemu-devel@nongnu.org; Wed, 27 Apr 2016 15:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avUyS-0005V8-EG for qemu-devel@nongnu.org; Wed, 27 Apr 2016 15:18:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avUyS-0005Uv-97 for qemu-devel@nongnu.org; Wed, 27 Apr 2016 15:18:12 -0400 References: <1461784125-578-1-git-send-email-dgilbert@redhat.com> <1461784125-578-3-git-send-email-dgilbert@redhat.com> From: Eric Blake Message-ID: <57211072.6060203@redhat.com> Date: Wed, 27 Apr 2016 13:18:10 -0600 MIME-Version: 1.0 In-Reply-To: <1461784125-578-3-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dAR4UHo79hJRatR1aC4Evqo5RAoLWcwTe" Subject: Re: [Qemu-devel] [PATCH 2/4] Postcopy: Add stats on page requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com Cc: aarcange@redhat.com, den@openvz.org, marcel.a@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dAR4UHo79hJRatR1aC4Evqo5RAoLWcwTe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2016 01:08 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > On the source, add a count of page requests received from the > destination. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > hmp.c | 4 +++ > include/migration/migration.h | 2 ++ > migration/migration.c | 59 ++++++++++++++++++-----------------= -------- > migration/ram.c | 1 + > qapi-schema.json | 6 ++++- > 5 files changed, 36 insertions(+), 36 deletions(-) >=20 > +++ b/migration/migration.c > @@ -561,6 +561,26 @@ static void get_xbzrle_cache_stats(MigrationInfo *= info) > } > } > =20 > +static void populate_ram_info(MigrationInfo *info, MigrationState *s) > +{ > + info->has_ram =3D true; > + info->ram =3D g_malloc0(sizeof(*info->ram)); > @@ -585,18 +605,7 @@ MigrationInfo *qmp_query_migrate(Error **errp) > info->has_setup_time =3D true; > info->setup_time =3D s->setup_time; > =20 > - info->has_ram =3D true; > - info->ram =3D g_malloc0(sizeof(*info->ram)); If you respin, please split the refactoring into one patch, and the addition of postcopy stats in another, so that the addition is not lost in the noise. Otherwise looks fine. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dAR4UHo79hJRatR1aC4Evqo5RAoLWcwTe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXIRByAAoJEKeha0olJ0NqwvAIAJaQctNwDlfFzHCsIk3CJ2oL fCN8pbMGtVLIChZq0JcZSMswb/23VrVionEsCT2F8G31V19RNoKFbaP+KEC2BB8m vqAOeRC+J6+W6GLbhOlUuUITjDzyLPxDGJi1AOXtAPvAdZBQS5aUTdkqG/3GqmmW hEI2KWH0/xVErzIJTJ7Pd9Ixfnqt1rQjZf0c98Y/0CjsVLR1beg1kgLFx2rZfPkf ZhFqyuuULKtujDhcU8s4B2iuFSSkanSEKCIOPMs+YIBJOPRLdutjkpJ98nD6IxP/ Q+UamMDD6mV+R+IixseLpED8tIxvpGq6Gmxd7ToWfn79vafj0S1gtEpoZM/R+Uc= =452c -----END PGP SIGNATURE----- --dAR4UHo79hJRatR1aC4Evqo5RAoLWcwTe--