From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH] ASoC: rt5651: remove unexisting widget Date: Thu, 28 Apr 2016 10:14:55 +0200 Message-ID: <5721C67F.2080007@metafoo.de> References: <1461809581-7863-1-git-send-email-bardliao@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from www381.your-server.de (www381.your-server.de [78.46.137.84]) by alsa0.perex.cz (Postfix) with ESMTP id 25C21265152 for ; Thu, 28 Apr 2016 10:15:03 +0200 (CEST) In-Reply-To: <1461809581-7863-1-git-send-email-bardliao@realtek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Bard Liao , broonie@kernel.org, lgirdwood@gmail.com Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org, john.lin@realtek.com, flove@realtek.com List-Id: alsa-devel@alsa-project.org On 04/28/2016 04:13 AM, Bard Liao wrote: > IN Muxes are not existing on rt5651. > > Signed-off-by: Bard Liao > --- > sound/soc/codecs/rt5651.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c > index 7a61970..b812c06 100644 > --- a/sound/soc/codecs/rt5651.c > +++ b/sound/soc/codecs/rt5651.c > @@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = { > RT5651_PWR_IN2_L_BIT, 0, NULL, 0), > SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL, > RT5651_PWR_IN2_R_BIT, 0, NULL, 0), > - /* IN Mux */ > - SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux), > - SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux), > - SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux), > - SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux), What is with the rt5651_in*_mux controls, those are unused now and can be removed as well, aren't they?