From: Jaroslav Kysela <perex@perex.cz>
To: mengdong.lin@linux.intel.com, alsa-devel@alsa-project.org,
broonie@kernel.org
Cc: tiwai@suse.de, mengdong.lin@intel.com,
guneshwor.o.singh@intel.com, liam.r.girdwood@intel.com,
hardik.t.shah@intel.com
Subject: Re: [PATCH 3/6] topology: Use generic pointer to realloc buffer for private data
Date: Thu, 28 Apr 2016 10:48:36 +0200 [thread overview]
Message-ID: <5721CE64.4060803@perex.cz> (raw)
In-Reply-To: <1dd0f08c152af476e3a5af48ce7de97cd759616a.1461831763.git.mengdong.lin@linux.intel.com>
Dne 28.4.2016 v 10:41 mengdong.lin@linux.intel.com napsal(a):
> priv_data_size = ref->data->size;
> + elem->obj = realloc(elem->obj,
> + elem->size + priv_data_size);
> + if (!elem->obj)
> + return -ENOMEM;
This causes a memory leak when realloc fails. You should free the
original pointer when realloc() fails.
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2016-04-28 8:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 8:40 [PATCH 0/6] topology: complete PCM parsing and code refactoring mengdong.lin
2016-04-28 8:41 ` [PATCH 1/6] topology: Set manifest size for ABI mengdong.lin
2016-04-28 8:41 ` [PATCH 2/6] topology: Refactor functions to parse and build streams mengdong.lin
2016-04-28 8:41 ` [PATCH 3/6] topology: Use generic pointer to realloc buffer for private data mengdong.lin
2016-04-28 8:48 ` Jaroslav Kysela [this message]
2016-04-28 13:55 ` Takashi Iwai
2016-04-28 14:30 ` Lin, Mengdong
2016-05-04 1:29 ` Mengdong Lin
2016-05-08 9:52 ` Takashi Iwai
2016-04-28 8:41 ` [PATCH 4/6] topology: Fix pcm ID & name parsing mengdong.lin
2016-04-28 8:42 ` [PATCH 5/6] topology: Parse front-end DAI name and ID for the PCM mengdong.lin
2016-04-28 8:42 ` [PATCH 6/6] topology: Update PCM configurations in Broadwell text conf file mengdong.lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721CE64.4060803@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guneshwor.o.singh@intel.com \
--cc=hardik.t.shah@intel.com \
--cc=liam.r.girdwood@intel.com \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.