From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Yu Zhang <yu.c.zhang@linux.intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org, Paul Durrant <paul.durrant@citrix.com>,
zhiyuan.lv@intel.com
Subject: Re: [PATCH for 4.7] Remove HVMMEM_mmio_write_dm from the public interface.
Date: Thu, 28 Apr 2016 11:42:47 +0100 [thread overview]
Message-ID: <5721E927.9020908@citrix.com> (raw)
In-Reply-To: <572200A202000078000E6BC3@prv-mh.provo.novell.com>
On 28/04/16 11:22, Jan Beulich wrote:
>>>> On 28.04.16 at 10:29, <yu.c.zhang@linux.intel.com> wrote:
>> @@ -5529,7 +5527,7 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg)
>> [HVMMEM_ram_rw] = p2m_ram_rw,
>> [HVMMEM_ram_ro] = p2m_ram_ro,
>> [HVMMEM_mmio_dm] = p2m_mmio_dm,
>> - [HVMMEM_mmio_write_dm] = p2m_mmio_write_dm
>> + [HVMMEM_unused] = p2m_invalid
>
> Why don't you simply delete the old line, without replacement?
That might have been slightly cleaner; but we're going to have to put it
back as soon as the development window opens anyway, so I don't really
see the point of going through the effort of respinning the patch again.
Would you be willing to ack this version anyway?
Thanks,
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-28 10:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 8:29 [PATCH for 4.7] Remove HVMMEM_mmio_write_dm from the public interface Yu Zhang
2016-04-28 9:30 ` Paul Durrant
2016-04-28 10:22 ` Jan Beulich
2016-04-28 10:41 ` Paul Durrant
2016-04-28 10:42 ` George Dunlap [this message]
2016-04-28 10:57 ` Jan Beulich
2016-04-28 11:40 ` Yu, Zhang
2016-04-28 11:52 ` Jan Beulich
2016-04-28 12:00 ` Yu, Zhang
2016-04-28 12:31 ` Jan Beulich
2016-04-28 11:59 ` Wei Liu
2016-04-28 12:00 ` Andrew Cooper
2016-04-28 12:06 ` Wei Liu
2016-04-28 12:12 ` Yu, Zhang
2016-04-28 12:39 ` Jan Beulich
2016-04-28 12:57 ` Yu, Zhang
2016-04-28 12:34 ` Jan Beulich
2016-04-28 12:46 ` Wei Liu
2016-04-28 10:43 ` George Dunlap
2016-04-28 10:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721E927.9020908@citrix.com \
--to=george.dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yu.c.zhang@linux.intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.