From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
Subject: Re: [PATCH v2 0/3] testpmd: extend commands for better
 scatter-gather tests
Date: Thu, 28 Apr 2016 15:19:08 +0200
Message-ID: <57220DCC.6010507@caviumnetworks.com>
References: <1461319098-22632-1-git-send-email-maciej.czekaj@caviumnetworks.com>
 <1461336680-7581-1-git-send-email-maciej.czekaj@caviumnetworks.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C912B66@IRSMSX108.ger.corp.intel.com>
 <5721FD7F.8040505@caviumnetworks.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C912F9A@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-bn1-obe.outbound.protection.outlook.com
 (mail-bn1bon0099.outbound.protection.outlook.com [157.56.111.99])
 by dpdk.org (Postfix) with ESMTP id E62162B83
 for <dev@dpdk.org>; Thu, 28 Apr 2016 15:19:22 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C912F9A@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 28 Apr 2016 13:13:20 +0000 De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: Maciej Czekaj [mailto:maciej.czekaj@caviumnetworks.com]
>> Sent: Thursday, April 28, 2016 1:10 PM
>> To: De Lara Guarch, Pablo; dev@dpdk.org
>> Cc: Mcnamara, John
>> Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for
>> better scatter-gather tests
>>
>> On Thu, 28 Apr 2016 08:52:59 +0000 De Lara Guarch, Pablo wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: maciej.czekaj@caviumnetworks.com
>>>> [mailto:maciej.czekaj@caviumnetworks.com]
>>>> Sent: Friday, April 22, 2016 3:51 PM
>>>> To: dev@dpdk.org
>>>> Cc: De Lara Guarch, Pablo; Mcnamara, John; Maciej Czekaj
>>>> Subject: [PATCH v2 0/3] testpmd: extend commands for better scatter-
>> gather
>>>> tests
>>>>
>>>> From: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
>>>>
>>>> v2:
>>>>    - included documentation changes
>>>>    - added value check for "port config all txqflags" as in --tqxflags
>> paramater
>>>>
>>>> Maciej Czekaj (3):
>>>>     app/testpmd: add "enable-scatter" parameter
>>>>     app/testpmd: extend port config with scatter parameter
>>>>     app/testpmd: support setting up txq_flags value in command line
>>>>
>>>>    app/test-pmd/cmdline.c                      | 86
>> +++++++++++++++++++++++++++--
>>>>    app/test-pmd/parameters.c                   |  3 +
>>>>    doc/guides/testpmd_app_ug/run_app.rst       |  4 ++
>>>>    doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 +++++++
>>>>    4 files changed, 109 insertions(+), 4 deletions(-)
>>>>
>>>> --
>>>> 1.9.1
>>>
>>> Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>>>
>>> Just one comment, maybe we should include some extra info in "show port
>> info all", like txqflags or scatter mode.
>>>
>>
>> txqflags is displayed in:
>>    - a forwarding info upon start command
>>    - show txq info
>>
>> scatter mode is displayed in:
>>    - show rxq info
>>
>> Still I think it is a good point to aggregate it in port info.
>>
>> I will address it in v3.
>
> Oh, true, good point. Then, probably not necessary, as we would be duplicating  information.
>

If you think it is not necessary to add another place for that info than 
I think we're fine with v2.