Re: [meta-networking][PATCH][jethro] samba: fix smbd and nmbd paths in sysv initscript

[Richard Leitner <richard.leitner@skidata.com>]

On 04/28/2016 02:52 PM, Joshua G Lock wrote:
> On Thu, 2016-04-28 at 14:30 +0200, Richard Leitner wrote:
>> For the jethro branch.
> 
> Any idea whether this change is required in the master branch?

Yes. The Samba 4.4.2 recipe is also using the script from
packaging/LSB/samba.sh, which is the same as in 4.1.12.

> 
>> The sysv initscript provided by samba assumes smbd and nmbd are
>> installed in /opt/samba/bin/. In our case both binaries are installed
>> to
>> /usr/sbin/ by default. Therefore fix these paths.
> 
> Rather than hard-code these in a patch, which is equally broken for
> people who don't use the default sbindir, it would make more sense to
> sed ${sbindir} into the init file in a do_install_append ().

Ok, you're right, that is definitely a better solution.
I'll prepare a patch for master and jethro.

regards,
Richard