From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees Date: Thu, 28 Apr 2016 18:26:12 +0200 Message-ID: <572239A4.3030100@i2se.com> References: <1454571364-24708-1-git-send-email-lkundrak@v3.sk> <1454571364-24708-2-git-send-email-lkundrak@v3.sk> <56B572D8.9030701@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olivier Blin , Lubomir Rintel , eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Chen , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Olivier Am 28.04.2016 um 14:52 schrieb Olivier Blin: > Stephen Warren writes: > >> On 02/04/2016 12:36 AM, Lubomir Rintel wrote: >>> The hub and the ethernet in its port 1 are hardwired on the board. >>> >>> Compared to the adapters that can be plugged into the USB ports, this >>> one has no serial EEPROM to store its MAC. Nevertheless, the Raspberry Pi >>> has the MAC address for this adapter in its ROM, accessible from its >>> firmware. >>> >>> U-Boot can read out the address and set the local-mac-address property of the >>> node with "ethernet" alias. Let's add the node so that U-Boot can do its >>> business. >>> >>> Model B rev2 and Model B+ entries were verified by me, the hierarchy and >>> pid/vid pair for the Version 2 was provided by Olivier Blin. Original >>> Model B is a blind short, though very likely correct. >> The series, >> Tested-by: Stephen Warren >> >> A few nits though... > [...] > > Is this still being queued in some tree? > Or does it need more fixes and a resubmit? Yes, a V3 should address the comments from Peter and Stephen. Regards Stefan > > Without this, Raspberry Pi devices boot with a random MAC address. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbcD1Q0x (ORCPT ); Thu, 28 Apr 2016 12:26:53 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:59961 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbcD1Q0v (ORCPT ); Thu, 28 Apr 2016 12:26:51 -0400 Subject: Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees To: Olivier Blin , Lubomir Rintel , eric@anholt.net References: <1454571364-24708-1-git-send-email-lkundrak@v3.sk> <1454571364-24708-2-git-send-email-lkundrak@v3.sk> <56B572D8.9030701@wwwdotorg.org> Cc: devicetree@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Peter Chen , linux-rpi-kernel@lists.infradead.org From: Stefan Wahren Message-ID: <572239A4.3030100@i2se.com> Date: Thu, 28 Apr 2016 18:26:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rMgoNAZn/pYnPHsUOTXEmN3jYGFIfmdGRNNx2qtQMxUzc3qoLG6 Zy9r4eq/s7H5W1foLujueL0GLODVLy9hlPagxdtk1uZkomFEtGf7wIa0BaqVj+7/AFRlZwa Ur0gekC82EiU+xXatNq0mIFRbg9bR0jP287IpEPGbMWXwafhGSbDLEi6lfmW6UsPbgiVWXI Vvyw5x9Li0J6u9/2NMy0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:7t3Drl1TR1I=:1lOjsO+2IxL2FZ0f94+dc9 pup/72xoWrARclhN0h5FwjWc0xhpEPO+QurHRd6gujDmizQgfRcJoxscJgD1i4m6EpzcxTzGW bPdSYjrVNcJJSu2cPSTWVWpbb2VEDeps4vgPBKc8pGRyqFcTAKQfRYY8qdl0mPcyDAuXNj6dW y1MKxPMlwgCFZI6E23A7uabmQGfPz1JuvVgoZv5agRh3xjZnyWPXAi/g/4q+02dMStalI+Ows odA6HUClE9JTMIAahAP5za4Jm5sTMHJUKjc6L2uQZ2kfUkxL0tMUWatPkfiBoZ3lC2fIFT9Bi Q2Pe0ivJ9LC2q3WRD3NjaFmy0iMVWK7AZbC4JqaBfyjkJ8VdJ+b4SXldj0TSlajQN4LUPf709 Lx0Ly7eBbyhXG1TpT8yAirpl2eyUFFXzucUU2rU1GoTWCn2tQxy/pHNBa/WINsbNA5G37I8/i p9jAnAIBPYqg3sqbvEQ26uuwjmHXoMgTKzgqPEpQUXdmXHCShcd9g3PCxHOrLwzk8gIgTjG9v XfC2kIUMr1iVX2W4ibPfjNlyFPeOEqp/T1pQqofsqPIPhzJPF4aWvD358AT0Qeom2K3RdSsb1 VHND7Qyqdf3L61ivFbA7tdotMRMFu9ZEHz3sYOyz+YJbAiPg7U1gGS4zvDfONZeF3vBAJZkl8 1G10hx/pJgo68MASDl8GMYjcwGUE2pyW/YEUzKrseigBVU9WYma9L1WQ2zR1d8x4yhDF2swrh 7oIgUBsJl5b7oZuZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Olivier Am 28.04.2016 um 14:52 schrieb Olivier Blin: > Stephen Warren writes: > >> On 02/04/2016 12:36 AM, Lubomir Rintel wrote: >>> The hub and the ethernet in its port 1 are hardwired on the board. >>> >>> Compared to the adapters that can be plugged into the USB ports, this >>> one has no serial EEPROM to store its MAC. Nevertheless, the Raspberry Pi >>> has the MAC address for this adapter in its ROM, accessible from its >>> firmware. >>> >>> U-Boot can read out the address and set the local-mac-address property of the >>> node with "ethernet" alias. Let's add the node so that U-Boot can do its >>> business. >>> >>> Model B rev2 and Model B+ entries were verified by me, the hierarchy and >>> pid/vid pair for the Version 2 was provided by Olivier Blin. Original >>> Model B is a blind short, though very likely correct. >> The series, >> Tested-by: Stephen Warren >> >> A few nits though... > [...] > > Is this still being queued in some tree? > Or does it need more fixes and a resubmit? Yes, a V3 should address the comments from Peter and Stephen. Regards Stefan > > Without this, Raspberry Pi devices boot with a random MAC address. >