Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

On 04/18/2016 05:11 AM, Zhang Chen wrote:

s/initlization/initialization/ in the subject

> packet come from primary char indev will be send to
> outdev - packet come from secondary char dev will be drop

Grammar suggestion:

Packets coming from the primary char indev will be sent to outdev;
packets coming from the secondary char dev will be dropped


> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---

> +/*
> + * called from the main thread on the primary
> + * for get packets

s/get/getting/

> +++ b/qemu-options.hx
> @@ -3866,6 +3866,12 @@ Dump the network traffic on netdev @var{dev} to the file specified by
>  The file format is libpcap, so it can be analyzed with tools such as tcpdump
>  or Wireshark.
>  
> +@item -object colo-compare,id=@var{id},primary_in=@var{chardevid},secondary_in=@var{chardevid},
> +outdev=@var{chardevid}
> +
> +Colo-compare get packet from primary_in@var{chardevid} and secondary_in@var{chardevid},

s/get/gets/

> +and output to outdev@var{chardevid}, we can use it with the help of filter-mirror and filter-redirector.

s/output/outputs/

Worth any better hints here about _how_ to use it with filter-mirror and
filter-redirector, or should the last phrase just be dropped?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]