From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avyLC-00054k-Q9 for qemu-devel@nongnu.org; Thu, 28 Apr 2016 22:39:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avyLB-00012E-T3 for qemu-devel@nongnu.org; Thu, 28 Apr 2016 22:39:38 -0400 References: <1461849406-29743-1-git-send-email-kwolf@redhat.com> <1461849406-29743-9-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5722C963.4070704@redhat.com> Date: Thu, 28 Apr 2016 20:39:31 -0600 MIME-Version: 1.0 In-Reply-To: <1461849406-29743-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tLfr2QeqqM2FwxsVgs2qnqjDBMw6X0xrD" Subject: Re: [Qemu-devel] [PATCH v2 08/17] dmg: Implement .bdrv_co_preadv() interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tLfr2QeqqM2FwxsVgs2qnqjDBMw6X0xrD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2016 07:16 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/dmg.c | 40 +++++++++++++++++++++++----------------- > 1 file changed, 23 insertions(+), 17 deletions(-) >=20 > if (dmg_read_chunk(bs, sector_num + i) !=3D 0) { > - return -1; > + ret =3D -EIO; > + goto fail; Same comment as for cloop. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tLfr2QeqqM2FwxsVgs2qnqjDBMw6X0xrD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXIsljAAoJEKeha0olJ0Nq0AEH/AveSNhtnG033uy9OEAVWdQx 4xUhpBtq0qzi6wdSsbXc1zDay944bvFA+AIW32bidB2QspiLx2v6KAqTRiR8geQv RW5C9YS7tOfYRUse8IudQ9j3IjRzsyIanbZzgrxt1d8/Cz5YXUodaoyVj5rhMyeg DBfz8j+abZw0StvvGL4qs2tlq1eIckdjDq/QVfkfuC4/3ye0OLPwPzh+enDsDi3E RPiV+tCuBK+JzsO0duDQzSDC9zcrAf0bYgpjmQd/2WwmeVE6cB/Pk1BqajOt0JNq qD7DG+hUsQYfCDrCYRjItlCOhNzKcaAWb8AIpYkYH7QYTSWk8s51ZHlviyQe95o= =7Eq4 -----END PGP SIGNATURE----- --tLfr2QeqqM2FwxsVgs2qnqjDBMw6X0xrD--