From: Eric Blake <eblake@redhat.com>
To: Zhou Jie <zhoujie2011@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: jcody@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] block: always compile-check debug prints
Date: Thu, 28 Apr 2016 22:15:02 -0600 [thread overview]
Message-ID: <5722DFC6.3010308@redhat.com> (raw)
In-Reply-To: <1461898826-24113-1-git-send-email-zhoujie2011@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On 04/28/2016 09:00 PM, Zhou Jie wrote:
> Files with conditional debug statements should ensure that the printf is
> always compiled.
> This prevents bitrot of the format string of the debug statement.
Still missing a sentence about the intentional change to use stderr.
>
> Signed-off-by: Zhou Jie <zhoujie2011@cn.fujitsu.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> v1 -> v2:
> * Keep the user-visible witness as defined/undefined,
> and create a secondary witness as the actual conditional.
> * Switch debug output to stderr.
You have it here, but anything after the --- separator gets stripped by
'git am', while we want the change to stderr to be documented as part of
the permanent commit log.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-04-29 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 3:00 [Qemu-devel] [PATCH v3] block: always compile-check debug prints Zhou Jie
2016-04-29 4:15 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5722DFC6.3010308@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhoujie2011@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.