From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw5y8-0005eV-F7 for qemu-devel@nongnu.org; Fri, 29 Apr 2016 06:48:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw5xw-0000K2-NQ for qemu-devel@nongnu.org; Fri, 29 Apr 2016 06:48:15 -0400 Received: from mail-db3on0133.outbound.protection.outlook.com ([157.55.234.133]:3808 helo=emea01-db3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw5xw-0000Ed-BY for qemu-devel@nongnu.org; Fri, 29 Apr 2016 06:48:08 -0400 References: <1461849406-29743-1-git-send-email-kwolf@redhat.com> <1461849406-29743-14-git-send-email-kwolf@redhat.com> <20160429030824.GE1421@ad.usersys.redhat.com> <57232000.9030701@virtuozzo.com> <20160429094932.GB4350@noname.redhat.com> From: Pavel Butsykin Message-ID: <57233818.1040406@virtuozzo.com> Date: Fri, 29 Apr 2016 13:31:52 +0300 MIME-Version: 1.0 In-Reply-To: <20160429094932.GB4350@noname.redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 13/17] vmdk: Implement .bdrv_co_pwritev() interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, sw@weilnetz.de, stefanha@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com On 29.04.2016 12:49, Kevin Wolf wrote: > Am 29.04.2016 um 10:49 hat Pavel Butsykin geschrieben: >> On 29.04.2016 06:08, Fam Zheng wrote: >>> On Thu, 04/28 15:16, Kevin Wolf wrote: >>>> static int vmdk_write_compressed(BlockDriverState *bs, >>>> int64_t sector_num, >>>> const uint8_t *buf, >>>> int nb_sectors) >>>> { >>>> BDRVVmdkState *s = bs->opaque; >>>> + >>>> if (s->num_extents == 1 && s->extents[0].compressed) { >>>> - return vmdk_write(bs, sector_num, buf, nb_sectors, false, false); >>>> + Coroutine *co; >>>> + AioContext *aio_context = bdrv_get_aio_context(bs); >>>> + VmdkWriteCompressedCo data = { >>>> + .bs = bs, >>>> + .sector_num = sector_num, >>>> + .buf = buf, >>>> + .nb_sectors = nb_sectors, >>>> + .ret = -EINPROGRESS, >>>> + }; >>>> + co = qemu_coroutine_create(vmdk_co_write_compressed); >>>> + qemu_coroutine_enter(co, &data); >>>> + while (data.ret == -EINPROGRESS) { >>>> + aio_poll(aio_context, true); >>>> + } >>>> + return data.ret; >>> >>> Don't you have a plan to make the creation of coroutine for compressed write in >>> in block layer? Or will bdrv_co_pwritev gain a "compressed" flag >>> (BDRV_REQ_COMPRESSED) in the future? >>> >> Actually, I already have these patches as part of the issue of backup >> compression, hope to send today. > > Sounds good. Do you use a new flag for the normal write functions or just > update the existing .bdrv_write_compressed function? > No, I just added a new interface .bdrv_co_write_compressed and removed the old. As for compatibility with the old interface in the bdrv_write_compressed will create a new coroutine and called bdrv_co_write_compressed, how you did it in the vmdk(only now is in io.c). Maybe it's not the best idea, but it can be discussed. > Also, please base your series on this one to avoid merge conflicts in > vmdk.c. I'm going to apply the series to block-next now as it's fully > reveiwed. I guess you'll effectively need to revert what this patch does > to vmdk_write_compressed() in favour of a block/io.c solution. > Yes, patches will be based on this series, I specifically made sure of it :) > Kevin >