From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t4622.austin.hp.com (g2t4622.austin.hp.com [15.73.212.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A4671A1F49 for ; Fri, 29 Apr 2016 06:53:54 -0700 (PDT) Subject: Re: [PATCH] nfit: fix format interface code byte order per ACPI6.1 References: <146189587309.28821.2994135280775533869.stgit@dwillia2-desk3.amr.corp.intel.com> From: Linda Knippers Message-ID: <5723676F.9000006@hpe.com> Date: Fri, 29 Apr 2016 09:53:51 -0400 MIME-Version: 1.0 In-Reply-To: <146189587309.28821.2994135280775533869.stgit@dwillia2-desk3.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: linux-nvdimm@lists.01.org List-ID: On 4/28/2016 10:11 PM, Dan Williams wrote: > ACPI6.1 clarifies that DCR fields are stored as an array of bytes, > update the format interface code constants to match. > > Cc: Toshi Kani > Signed-off-by: Dan Williams > --- > drivers/acpi/nfit.h | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/acpi/nfit.h b/drivers/acpi/nfit.h > index c75576b2d50e..92ea5d06c7fe 100644 > --- a/drivers/acpi/nfit.h > +++ b/drivers/acpi/nfit.h > @@ -41,11 +41,13 @@ enum nfit_uuids { > NFIT_UUID_MAX, > }; > > -enum nfit_fic { > - NFIT_FIC_BYTE = 0x101, /* byte-addressable energy backed */ > - NFIT_FIC_BLK = 0x201, /* block-addressable non-energy backed */ > - NFIT_FIC_BYTEN = 0x301, /* byte-addressable non-energy backed */ > -}; > +/* > + * Region format interface codes are stored as an array of bytes in the > + * NFIT DIMM Control Region structure > + */ > +#define NFIT_FIC_BYTE cpu_to_be16(0x101) /* byte-addressable energy */ energy backed? > +#define NFIT_FIC_BLK cpu_to_be16(0x201) /* block-addressable non-energy backed */ > +#define NFIT_FIC_BYTEN cpu_to_be16(0x301) /* byte-addressable non-energy backed */ > > enum { > NFIT_BLK_READ_FLUSH = 1, > > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm