From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 0/3] mxs-lradc: Add support for current sources To: Harald Geyer , Jonathan Cameron , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Shawn Guo , Sascha Hauer References: <1461333147-11873-1-git-send-email-harald@ccbib.org> Cc: Marek Vasut , linux-arm-kernel@lists.infradead.org From: Stefan Wahren Message-ID: <572379F5.8000501@i2se.com> Date: Fri, 29 Apr 2016 17:12:53 +0200 MIME-Version: 1.0 In-Reply-To: <1461333147-11873-1-git-send-email-harald@ccbib.org> Content-Type: text/plain; charset=iso-8859-15 List-ID: Hi Harald, Am 22.04.2016 um 15:52 schrieb Harald Geyer: > Patch 1/3 changes the driver and updates the binding documentation > (I guess it is still in staging.) > > Patches 2/3 and 3/3 add the devicetree nodes to imx23 and imx28 boards. > I'd like to get input whether this is actually desired. On boards where > these regulators would never be enabled this costs a few extra bytes of > RAM for allocation of the device data, because the nodes can't be easily > removed in .dts files which are including the .dtsi files. The alternative > is to add the new nodes to many .dts files, which would be a lot code > duplication. if i get it right the real intention of this patch series is to make the mxs-lradc provide resistance values instead of voltages. So how about dropping the whole regulator stuff and provide the values as IIO_RESISTANCE via iio interface? Btw this feature should be only added to dts files where is actually used. Regards Stefan > > Harald Geyer (3): > iio: mxs-lradc: Add regulators for current sources > ARM: dts: imx23: Provide regulators for the current sources of the > LRADC > ARM: dts: imx28: Provide regulators for the current sources of the > LRADC > > .../bindings/staging/iio/adc/mxs-lradc.txt | 29 ++++ > arch/arm/boot/dts/imx23.dtsi | 8 ++ > arch/arm/boot/dts/imx28.dtsi | 8 ++ > drivers/iio/adc/Kconfig | 1 + > drivers/iio/adc/mxs-lradc.c | 152 +++++++++++++++++++++ > 5 files changed, 198 insertions(+) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan.wahren@i2se.com (Stefan Wahren) Date: Fri, 29 Apr 2016 17:12:53 +0200 Subject: [PATCH 0/3] mxs-lradc: Add support for current sources In-Reply-To: <1461333147-11873-1-git-send-email-harald@ccbib.org> References: <1461333147-11873-1-git-send-email-harald@ccbib.org> Message-ID: <572379F5.8000501@i2se.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Harald, Am 22.04.2016 um 15:52 schrieb Harald Geyer: > Patch 1/3 changes the driver and updates the binding documentation > (I guess it is still in staging.) > > Patches 2/3 and 3/3 add the devicetree nodes to imx23 and imx28 boards. > I'd like to get input whether this is actually desired. On boards where > these regulators would never be enabled this costs a few extra bytes of > RAM for allocation of the device data, because the nodes can't be easily > removed in .dts files which are including the .dtsi files. The alternative > is to add the new nodes to many .dts files, which would be a lot code > duplication. if i get it right the real intention of this patch series is to make the mxs-lradc provide resistance values instead of voltages. So how about dropping the whole regulator stuff and provide the values as IIO_RESISTANCE via iio interface? Btw this feature should be only added to dts files where is actually used. Regards Stefan > > Harald Geyer (3): > iio: mxs-lradc: Add regulators for current sources > ARM: dts: imx23: Provide regulators for the current sources of the > LRADC > ARM: dts: imx28: Provide regulators for the current sources of the > LRADC > > .../bindings/staging/iio/adc/mxs-lradc.txt | 29 ++++ > arch/arm/boot/dts/imx23.dtsi | 8 ++ > arch/arm/boot/dts/imx28.dtsi | 8 ++ > drivers/iio/adc/Kconfig | 1 + > drivers/iio/adc/mxs-lradc.c | 152 +++++++++++++++++++++ > 5 files changed, 198 insertions(+) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH 0/3] mxs-lradc: Add support for current sources Date: Fri, 29 Apr 2016 17:12:53 +0200 Message-ID: <572379F5.8000501@i2se.com> References: <1461333147-11873-1-git-send-email-harald@ccbib.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1461333147-11873-1-git-send-email-harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Harald Geyer , Jonathan Cameron , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shawn Guo , Sascha Hauer Cc: Marek Vasut , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Harald, Am 22.04.2016 um 15:52 schrieb Harald Geyer: > Patch 1/3 changes the driver and updates the binding documentation > (I guess it is still in staging.) > > Patches 2/3 and 3/3 add the devicetree nodes to imx23 and imx28 boards. > I'd like to get input whether this is actually desired. On boards where > these regulators would never be enabled this costs a few extra bytes of > RAM for allocation of the device data, because the nodes can't be easily > removed in .dts files which are including the .dtsi files. The alternative > is to add the new nodes to many .dts files, which would be a lot code > duplication. if i get it right the real intention of this patch series is to make the mxs-lradc provide resistance values instead of voltages. So how about dropping the whole regulator stuff and provide the values as IIO_RESISTANCE via iio interface? Btw this feature should be only added to dts files where is actually used. Regards Stefan > > Harald Geyer (3): > iio: mxs-lradc: Add regulators for current sources > ARM: dts: imx23: Provide regulators for the current sources of the > LRADC > ARM: dts: imx28: Provide regulators for the current sources of the > LRADC > > .../bindings/staging/iio/adc/mxs-lradc.txt | 29 ++++ > arch/arm/boot/dts/imx23.dtsi | 8 ++ > arch/arm/boot/dts/imx28.dtsi | 8 ++ > drivers/iio/adc/Kconfig | 1 + > drivers/iio/adc/mxs-lradc.c | 152 +++++++++++++++++++++ > 5 files changed, 198 insertions(+) >