From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
stephen@networkplumber.org, jhs@mojatatu.com
Subject: Re: [PATCH net-next v2 0/5] bridge: per-vlan stats
Date: Fri, 29 Apr 2016 22:19:42 +0200 [thread overview]
Message-ID: <5723C1DE.4050109@cumulusnetworks.com> (raw)
In-Reply-To: <20160429.161208.1214717753456694357.davem@davemloft.net>
On 04/29/2016 10:12 PM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Date: Fri, 29 Apr 2016 21:49:17 +0200
>
>> Because that is not needed for the per-vlan stats to work, I did to
>> unify the paths and simplify the pvid code but I can easily drop it
>> and revert back to using the direct pvid id. The only fetch will be
>> the stats per-cpu pointer then. Would that be acceptable ?
>
> It would be a step in the right direction, for sure.
>
Okay, just one more thing I forgot to mention - please note that my code swaps
an unconditional smp_rmb() (in br_get_pvid()) for a pointer fetch, I'm not sure
the pointer fetch is slower as it's probably already in the cache if that vlan
is used.
Anyway, I will resubmit without that patch.
Thanks,
Nik
prev parent reply other threads:[~2016-04-29 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 15:52 [PATCH net-next v2 0/5] bridge: per-vlan stats Nikolay Aleksandrov
2016-04-28 15:52 ` [PATCH net-next v2 1/5] net: rtnetlink: allow rtnl_fill_statsinfo to save private state counter Nikolay Aleksandrov
2016-04-28 15:52 ` [PATCH net-next v2 2/5] net: rtnetlink: add linkxstats callbacks and attribute Nikolay Aleksandrov
2016-04-28 15:52 ` [PATCH net-next v2 3/5] bridge: vlan: RCUify pvid Nikolay Aleksandrov
2016-04-28 15:52 ` [PATCH net-next v2 4/5] bridge: vlan: learn to count Nikolay Aleksandrov
2016-04-28 15:52 ` [PATCH net-next v2 5/5] bridge: netlink: export per-vlan stats Nikolay Aleksandrov
2016-04-29 19:33 ` [PATCH net-next v2 0/5] bridge: " David Miller
2016-04-29 19:49 ` Nikolay Aleksandrov
2016-04-29 20:12 ` David Miller
2016-04-29 20:19 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5723C1DE.4050109@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.