Re: [PoC 0/7] Kobjectify filesystem

[Goldwyn Rodrigues <rgoldwyn@suse.de>]

On 04/29/2016 05:31 PM, Al Viro wrote:
> On Fri, Apr 29, 2016 at 01:28:00PM -0500, Goldwyn Rodrigues wrote:
>
>> Yes, you can register any attribute to sysfs, and most filesystems
>> are doing exactly that. They maintain the kobject in their
>> <fs>_super_block struct and use it to create /sys/fs/<fstype>/<id>
>> entries. So what I propose is this:
>
> [snip]
>
> What's really missing here is
>
> 0. carefully audit the existing sysfs users of that sort - they are _very_
> easy to get wrong, especially wrt lifetime issues and locking.  As you have
> demonstrated yourself in this patchset, BTW...
>

Agree. And I  accept the way I have used the kobjects in this patchset 
is incorrect. I am reading on existing usage to get this right and have 
not yet completed my reading. Thank you for pointing me to the right 
direction.

However, if you feel that it is absolutely infeasible to use kobjects at 
all in these fs structures with respect to lifetime and locking, please 
let me know the reason and I will stop my effort in this direction and 
think of alternative ways to do this.

-- 
Goldwyn