From: Eli Billauer <eli.billauer@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] char: xillybus: use devm_add_action_or_reset
Date: Sun, 01 May 2016 09:28:04 +0300 [thread overview]
Message-ID: <5725A1F4.20606@gmail.com> (raw)
In-Reply-To: <1462032800-24783-1-git-send-email-sudipm.mukherjee@gmail.com>
Fine with me. Thanks.
Acked-by: Eli Billauer <eli.billauer@gmail.com>
On 30/04/16 19:13, Sudip Mukherjee wrote:
> If devm_add_action() fails we are explicitly calling dma_unmap_single(),
> pci_unmap_single() and kfree(). Lets use the helper
> devm_add_action_or_reset() and return directly in case of error, as we
> know that the cleanup function has been already called by the helper if
> there was any error. At that same time remove the variable rc which
> becomes unused now.
>
> Signed-off-by: Sudip Mukherjee<sudip.mukherjee@codethink.co.uk>
> ---
>
>
prev parent reply other threads:[~2016-05-01 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 16:13 [PATCH v2] char: xillybus: use devm_add_action_or_reset Sudip Mukherjee
2016-05-01 6:28 ` Eli Billauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5725A1F4.20606@gmail.com \
--to=eli.billauer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.