Re: acpi_nfit_query_poison() broken on non-ARS systems

[Linda Knippers <linda.knippers@hpe.com>]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]



On 5/1/2016 1:42 PM, Linda Knippers wrote:
<snip>
>>
>> Can you add some debug tracing to xlat_status()?  Something is not lining up.

I put a printk at the top of xlat_status() as well as in each case statement.
> 
> xlat_status() is not called from acpi_nfit_query_poison(), which is called at
> boot time.  Not sure if we're getting there from acpi_nfit_scrub() or
> acpi_nfit_async_scrub().

Ok, it actually is being called, but only for the start command.  See attached.

BTW, this is with your rewrite of Jerry's patches but I saw the same
behavior before I applied them as that's what the previous dmesg output
was from.

One thing you'll notice in this new dmesg output is that unlike before,
the acpi_nfit_ctl() function prints the DSM number, not the DSM name,
when displaying the input. It prints the DSM name when displaying the
output.

-- ljk
> 
> -- ljk
> 

[-- Attachment #2: ars_debug.txt --]
[-- Type: text/plain, Size: 6085 bytes --]

[   33.770104] nfit ACPI0012:00: add_spa: spa index: 1 type: pmem
[   33.770107] nfit ACPI0012:00: add_memdev: memdev handle: 0x10 spa: 1 dcr: 1
[   33.770109] nfit ACPI0012:00: add_dcr: dcr index: 1 windows: 0
[   33.770111] nfit ACPI0012:00: add_spa: spa index: 2 type: pmem
[   33.770113] nfit ACPI0012:00: add_memdev: memdev handle: 0x120 spa: 2 dcr: 2
[   33.770115] nfit ACPI0012:00: add_dcr: dcr index: 2 windows: 0
[   33.770116] nfit ACPI0012:00: add_spa: spa index: 3 type: pmem
[   33.770118] nfit ACPI0012:00: add_memdev: memdev handle: 0x1010 spa: 3 dcr: 3
[   33.770120] nfit ACPI0012:00: add_dcr: dcr index: 3 windows: 0
[   33.770122] nfit ACPI0012:00: add_spa: spa index: 4 type: pmem
[   33.770123] nfit ACPI0012:00: add_memdev: memdev handle: 0x1120 spa: 4 dcr: 4
[   33.770125] nfit ACPI0012:00: add_dcr: dcr index: 4 windows: 0
[   33.771719] nvdimm nmem0: nvdimm_init_nsarea [libnvdimm]: validate_dimm error: -6
[   33.771721] nvdimm nmem0: nvdimm_drvdata_release
[   33.771724]  ndbus0: nvdimm.probe(nmem0) = -6
[   33.772229] nvdimm nmem1: nvdimm_init_nsarea [libnvdimm]: validate_dimm error: -6
[   33.772230] nvdimm nmem1: nvdimm_drvdata_release
[   33.772232]  ndbus0: nvdimm.probe(nmem1) = -6
[   33.773135] nvdimm nmem2: nvdimm_init_nsarea [libnvdimm]: validate_dimm error: -6
[   33.773136] nvdimm nmem2: nvdimm_drvdata_release
[   33.773138]  ndbus0: nvdimm.probe(nmem2) = -6
[   33.774084] nvdimm nmem3: nvdimm_init_nsarea [libnvdimm]: validate_dimm error: -6
[   33.774086] nvdimm nmem3: nvdimm_drvdata_release
[   33.774087]  ndbus0: nvdimm.probe(nmem3) = -6
[   33.774101]  ndbus0: nvdimm_bus_check_dimm_count: count: 4
[   33.774115] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: 1: func: 1 input length: 16
[   33.774119] nvdimm in  00000000: 80000000 00000004 00000000 00000002  ................
[   33.774306] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: ars_cap output length: 16
[   33.774309] ars_cap00000000: 00000001 00000000 00000000 00000000  ................
[   33.774347] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: 1: func: 1 input length: 16
[   33.774350] nvdimm in  00000000: 80000000 00000006 00000000 00000002  ................
[   33.774416]  ndbus0: nd_region.probe(region0) = 0
[   33.774501] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: ars_cap output length: 16
[   33.774503] ars_cap00000000: 00000001 00000000 00000000 00000000  ................
[   33.774545] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: 2: func: 2 input length: 24
[   33.774547] nvdimm in  00000000: 80000000 00000006 00000000 00000002  ................
[   33.774549] nvdimm in  00000010: 00000002 00000000                    ........
[   33.774602]  ndbus0: nd_region.probe(region1) = 0
[   33.774662] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: ars_start output length: 4
[   33.774664] ars_start00000000: 00000001                             ....
[   33.774668] nfit ACPI0012:00: acpi_nfit_ctl:bus output object underflow cmd: ars_start field: 1
[   33.774670]  ndbus0: nd_region.probe(region2) = 0
[   33.774671] xlat_status: called with cmd 2
[   33.774672] xlat_status: ND_CMD_ARS_START status 0x1
[   33.774676] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: 2: func: 2 input length: 24
[   33.774678]  ndbus0: nd_region.probe(region3) = 0
[   33.774680] nvdimm in  00000000: 80000000 0000000c 00000000 00000002  ................
[   33.774683] nvdimm in  00000010: 00000002 00000000                    ........
[   33.774783] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: ars_start output length: 4
[   33.774784] ars_start00000000: 00000001                             ....
[   33.774786] nfit ACPI0012:00: acpi_nfit_ctl:bus output object underflow cmd: ars_start field: 1
[   33.774787] xlat_status: called with cmd 2
[   33.774787] xlat_status: ND_CMD_ARS_START status 0x1
[   33.774789] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: 2: func: 2 input length: 24
[   33.774791] nvdimm in  00000000: 80000000 0000000e 00000000 00000002  ................
[   33.774793] nvdimm in  00000010: 00000002 00000000                    ........
[   33.774875] nfit ACPI0012:00: acpi_nfit_ctl:bus cmd: ars_start output length: 4
[   33.774876] ars_start00000000: 00000001                             ....
[   33.774878] nfit ACPI0012:00: acpi_nfit_ctl:bus output object underflow cmd: ars_start field: 1
[   33.774879] xlat_status: called with cmd 2
[   33.774879] xlat_status: ND_CMD_ARS_START status 0x1
[   34.230367] nd_pmem namespace0.0: unable to guarantee persistence of writes
[   34.264312] nd_pmem namespace0.0: nd_btt_probe: btt: btt0.1
[   34.278381]  ndbus0: nd_pmem.probe(namespace0.0) = -6
[   34.278459] nd_pmem btt0.1: unable to guarantee persistence of writes
[   34.278464]  ndbus0: nd_pmem.probe(btt0.0) = -19
[   34.278490] nd_pmem namespace1.0: unable to guarantee persistence of writes
[   34.278664] nd_pmem namespace1.0: nd_btt_probe: btt: <none>
[   34.278665]  btt1.1: nd_btt_release
[   34.279153] pmem1: detected capacity change from 0 to 8589934592
[   34.279157]  ndbus0: nd_pmem.probe(namespace1.0) = 0
[   34.279164]  ndbus0: nd_pmem.probe(btt1.0) = -19
[   34.279173] nd_pmem namespace2.0: unable to guarantee persistence of writes
[   34.279325] nd_pmem namespace2.0: nd_btt_probe: btt: btt2.1
[   34.404932]  ndbus0: nd_pmem.probe(namespace2.0) = -6
[   34.404950] nd_pmem btt2.1: unable to guarantee persistence of writes
[   34.404954]  ndbus0: nd_pmem.probe(btt2.0) = -19
[   34.404960]  ndbus0: nd_pmem.probe(btt3.0) = -19
[   34.404969] nd_pmem namespace3.0: unable to guarantee persistence of writes
[   34.405125] nd_pmem namespace3.0: nd_btt_probe: btt: btt3.1
[   34.468103]  ndbus0: nd_pmem.probe(namespace3.0) = -6
[   34.468130] nd_pmem btt3.1: unable to guarantee persistence of writes
[   34.468431] pmem0s: detected capacity change from 0 to 8523182080
[   34.468486]  ndbus0: nd_pmem.probe(btt0.1) = 0
[   34.528239] pmem3s: detected capacity change from 0 to 8580472832
[   34.529055] pmem2s: detected capacity change from 0 to 8580472832
[   34.529126]  ndbus0: nd_pmem.probe(btt2.1) = 0
[   34.684833]  ndbus0: nd_pmem.probe(btt3.1) = 0

[-- Attachment #3: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm