From: Laxman Dewangan <ldewangan@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Paweł Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexandre Courbot" <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Stephen Warren" <swarren@nvidia.com>,
"Thierry Reding" <treding@nvidia.com>
Subject: Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024
Date: Mon, 2 May 2016 11:47:44 +0530 [thread overview]
Message-ID: <5726F108.2050805@nvidia.com> (raw)
In-Reply-To: <CACRpkdZxVsGkC1U5Y9+M1fh6Z1T_ZBZC4eyH4ryzBijUq2hvCg@mail.gmail.com>
On Saturday 30 April 2016 05:08 PM, Linus Walleij wrote:
> On Thu, Apr 28, 2016 at 11:59 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
>> pins. It also supports interrupts from these pins.
>>
>> Add GPIO driver for these pins to control via GPIO APIs.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Gnah there is still a problem with this, I just saw it:
>
>> +config GPIO_MAX77620
>> + bool "GPIO support for PMIC MAX77620 and MAX20024"
> bool == not a module
Yaah, looked the changes from Gortmaker.
The things are evolving faster.
I think we can change "bool" to "tristate" here.
Then there is no need to have code change. MFD driver is already said as
tristate.
I will wait for Lee's comment on this series patch before recycling the
patch. (Already on V11 :-( ).
prev parent reply other threads:[~2016-05-02 6:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 9:58 [PATCH V11 0/6] Add support for MAXIM MAX77620/MAX20024 PMIC Laxman Dewangan
2016-04-28 9:58 ` Laxman Dewangan
2016-04-28 9:58 ` [PATCH V11 1/6] mfd: add device-tree binding doc for PMIC max77620/max20024 Laxman Dewangan
2016-04-28 9:58 ` Laxman Dewangan
[not found] ` <1461837540-17071-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-09 14:38 ` Lee Jones
2016-05-09 14:38 ` Lee Jones
2016-04-28 9:58 ` [PATCH V11 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan
2016-04-28 9:58 ` Laxman Dewangan
2016-05-09 14:38 ` Lee Jones
2016-04-28 9:58 ` [PATCH V11 3/6] pinctrl: add DT binding doc for pincontrol of PMIC max77620/max20024 Laxman Dewangan
2016-04-28 9:58 ` Laxman Dewangan
2016-04-28 9:58 ` [PATCH V11 4/6] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Laxman Dewangan
2016-04-28 9:58 ` Laxman Dewangan
2016-04-28 13:22 ` Laxman Dewangan
2016-04-28 13:22 ` Laxman Dewangan
[not found] ` <57220E92.90105-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-29 13:27 ` Thierry Reding
2016-04-29 13:27 ` Thierry Reding
2016-04-28 9:58 ` [PATCH V11 5/6] gpio: add DT binding doc for gpio of PMIC max77620/max20024 Laxman Dewangan
2016-04-28 9:58 ` Laxman Dewangan
2016-04-28 9:59 ` [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan
2016-04-28 9:59 ` Laxman Dewangan
2016-04-30 11:38 ` Linus Walleij
2016-05-02 6:17 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5726F108.2050805@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.