diff for duplicates of <572715C5.6070700@sperl.org> diff --git a/a/1.txt b/N1/1.txt index b895a03..957ebcd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,15 +14,15 @@ On 30.04.2016 11:28, Martin Sperl wrote: >> >> Signed-off-by: Eric Anholt <eric@anholt.net> >> Fixes: 41691b8862e2 ("clk: bcm2835: Add support for programming the audio domain clocks") ->> ? +>> — > I guess this patch looks to me as if it is a policy inside the kernel, > which is AFAIK frowned upon. > -> I am looking into making "assigned-clock-parents? inside the dt +> I am looking into making "assigned-clock-parents” inside the dt > work with the driver. > > Could look something like this: -> i2s: i2s at 7e203000 { +> i2s: i2s@7e203000 { > assigned-clock-parents = <&cprman BCM2835_PLLD_PER>, <&clk_osc>; > assigned-clocks = <&cprman BCM2835_CLOCK_PCM>, <&cprman BCM2835_CLOCK_PCM>; > }; @@ -43,7 +43,7 @@ it would and once with clk_osc. So I start to wonder if it would not be better to use an approach like this: -cprman: cprman at 7e101000 { +cprman: cprman@7e101000 { ... brcm,clock-flags = <flags for PCM>, <flags for PWM>; brcm,clock-index = <BCM2835_CLOCK_PCM>, <BCM2835_CLOCK_PWM>; @@ -52,7 +52,7 @@ cprman: cprman at 7e101000 { the flags would be a bitfield that select the parent clocks. So it could look like this: -cprman: cprman at 7e101000 { +cprman: cprman@7e101000 { ... brcm,clock-flags = (BIT(BCM2835_PER_PARENT_OSC) | BIT(BCM2835_PER_PARENT_PLLD_PER)), ...; diff --git a/a/content_digest b/N1/content_digest index a0b568a..5507900 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,18 @@ "ref\01461699585-6649-1-git-send-email-eric@anholt.net\0" "ref\01461699585-6649-2-git-send-email-eric@anholt.net\0" "ref\0C771F70C-2F88-49E1-A370-D76D13262C1E@martin.sperl.org\0" - "From\0martin@sperl.org (Martin Sperl)\0" - "Subject\0[PATCH 2/2] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent\0" + "From\0Martin Sperl <martin@sperl.org>\0" + "Subject\0Re: [PATCH 2/2] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent\0" "Date\0Mon, 2 May 2016 10:54:29 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Eric Anholt <eric@anholt.net>\0" + "Cc\0Michael Turquette <mturquette@baylibre.com>" + Stephen Boyd <sboyd@codeaurora.org> + linux-rpi-kernel@lists.infradead.org + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + Stephen Warren <swarren@wwwdotorg.org> + Lee Jones <lee@kernel.org> + " devicetree@vger.kernel.org <devicetree@vger.kernel.org>\0" "\00:1\0" "b\0" "\n" @@ -23,15 +31,15 @@ ">>\n" ">> Signed-off-by: Eric Anholt <eric@anholt.net>\n" ">> Fixes: 41691b8862e2 (\"clk: bcm2835: Add support for programming the audio domain clocks\")\n" - ">> ?\n" + ">> \342\200\224\n" "> I guess this patch looks to me as if it is a policy inside the kernel,\n" "> which is AFAIK frowned upon.\n" ">\n" - "> I am looking into making \"assigned-clock-parents? inside the dt\n" + "> I am looking into making \"assigned-clock-parents\342\200\235 inside the dt\n" "> work with the driver.\n" ">\n" "> Could look something like this:\n" - "> i2s: i2s at 7e203000 {\n" + "> i2s: i2s@7e203000 {\n" "> \tassigned-clock-parents = <&cprman BCM2835_PLLD_PER>, <&clk_osc>;\n" "> \tassigned-clocks = <&cprman BCM2835_CLOCK_PCM>, <&cprman BCM2835_CLOCK_PCM>;\n" "> };\n" @@ -52,7 +60,7 @@ " and once with clk_osc.\n" "\n" "So I start to wonder if it would not be better to use an approach like this:\n" - "cprman: cprman at 7e101000 {\n" + "cprman: cprman@7e101000 {\n" " ...\n" " brcm,clock-flags = <flags for PCM>, <flags for PWM>;\n" " brcm,clock-index = <BCM2835_CLOCK_PCM>, <BCM2835_CLOCK_PWM>;\n" @@ -61,7 +69,7 @@ "the flags would be a bitfield that select the parent clocks.\n" "\n" "So it could look like this:\n" - "cprman: cprman at 7e101000 {\n" + "cprman: cprman@7e101000 {\n" " ...\n" " brcm,clock-flags = (BIT(BCM2835_PER_PARENT_OSC) |\n" "BIT(BCM2835_PER_PARENT_PLLD_PER)), ...;\n" @@ -85,4 +93,4 @@ "Thanks,\n" Martin -63c16e47d396828bb84bd00ae8116b767430b87d213805d4563cb84c472f66e5 +dae18d0bfae10846566b75f41aea5615c41226479cf3f79782ce227ea338b474
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.