From: Steve Dickson <SteveD@redhat.com>
To: Scott Mayhew <smayhew@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH v2] exportfs: add the debug option
Date: Mon, 2 May 2016 10:54:27 -0400 [thread overview]
Message-ID: <57276A23.7080404@RedHat.com> (raw)
In-Reply-To: <1461946437-2740-1-git-send-email-smayhew@redhat.com>
On 29/04/16 12:13, Scott Mayhew wrote:
> Since calling xlog(D_GENERAL) will cause exportfs to exit with a status
> of 1, there really should be a way to see those messages for debugging
> purposes.
>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed...
steved.
> ---
> utils/exportfs/exportfs.c | 7 +++++--
> utils/exportfs/exportfs.man | 3 +++
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index a9151ff..5db348b 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -108,11 +108,14 @@ main(int argc, char **argv)
> xlog_stderr(1);
> xlog_syslog(0);
>
> - while ((c = getopt(argc, argv, "afhio:ruvs")) != EOF) {
> + while ((c = getopt(argc, argv, "ad:fhio:ruvs")) != EOF) {
> switch(c) {
> case 'a':
> f_all = 1;
> break;
> + case 'd':
> + xlog_sconfig(optarg, 1);
> + break;
> case 'f':
> force_flush = 1;
> break;
> @@ -878,6 +881,6 @@ error(nfs_export *exp, int err)
> static void
> usage(const char *progname, int n)
> {
> - fprintf(stderr, "usage: %s [-afhioruvs] [host:/path]\n", progname);
> + fprintf(stderr, "usage: %s [-adfhioruvs] [host:/path]\n", progname);
> exit(n);
> }
> diff --git a/utils/exportfs/exportfs.man b/utils/exportfs/exportfs.man
> index 75d952a..fdf9260 100644
> --- a/utils/exportfs/exportfs.man
> +++ b/utils/exportfs/exportfs.man
> @@ -88,6 +88,9 @@ appropriate export entry for the host given in
> to be added to the kernel's export table.
> .SH OPTIONS
> .TP
> +.B \-d kind " or " \-\-debug kind
> +Turn on debugging. Valid kinds are: all, auth, call, general and parse.
> +.TP
> .B -a
> Export or unexport all directories.
> .TP
>
prev parent reply other threads:[~2016-05-02 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 16:13 [nfs-utils PATCH v2] exportfs: add the debug option Scott Mayhew
2016-05-02 14:54 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57276A23.7080404@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.